465396 – Remove the @SuppressWarnings("nls") in the generated template files

Bug 465396 - Remove the @SuppressWarnings("nls") in the generated template files

Summary: Remove the @SuppressWarnings("nls") in the generated template files

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Mac OS X

Importance:	P3 normal (vote)
Target Milestone:	4.5 M7
Assignee:	Olivier Prouvost
QA Contact:

URL:
Whiteboard:
Keywords:	greatfix

Depends on:
Blocks:

Reported:	2015-04-24 05:37 EDT by Olivier Prouvost
Modified:	2015-04-28 15:25 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Olivier Prouvost

2015-04-24 05:37:39 EDT

This bug concerns the following files : 

DynamicMenuContributionTemplate.java
HandlerTemplate.java
PartTemplate.java
ToolControlTemplate.java

in the package : org.eclipse.e4.internal.tools.wizards.classes.templates

They are automatically rebuilt by the JET builder and they do not contain the @SuppressWarning("nls"). So each time the project is rebuilt, these 4 files are shown as changed.

It as already be done for the AddonTemplate.java file in the same package.

Comment 1 Eclipse Genie

2015-04-24 05:39:55 EDT

New Gerrit change created: https://git.eclipse.org/r/46401

Comment 2 Eclipse Genie

2015-04-28 09:47:18 EDT

New Gerrit change created: https://git.eclipse.org/r/46682

Comment 3 Eclipse Genie

2015-04-28 14:32:21 EDT

Gerrit change https://git.eclipse.org/r/46682 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=d05e13c2a195baec6c0fd7efe2ba727b943981fc

Comment 4 Lars Vogel

2015-04-28 14:32:36 EDT

Thanks Olivier.

Comment 5 Lars Vogel

2015-04-28 15:25:57 EDT