Bug 465065 - ToolBar not properly styled in dark theme on latest M7
Summary: ToolBar not properly styled in dark theme on latest M7
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Fabio Zadrozny CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2015-04-20 19:27 EDT by Fabio Zadrozny CLA
Modified: 2015-04-28 06:21 EDT (History)
1 user (show)

See Also:

Attachments
ToolBar on windows with and without the patch. (16.68 KB, image/png)
2015-04-20 19:31 EDT, Fabio Zadrozny CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Zadrozny CLA 2015-04-20 19:27:03 EDT 
It seems the previous fix to style E4 dark somehow removed the ToolBar styling (at least it looks strange for me).

I'm going to upload a patch shortly.
Comment 1 Eclipse Genie CLA 2015-04-20 19:29:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/46140
Comment 2 Fabio Zadrozny CLA 2015-04-20 19:31:19 EDT 
Created attachment 252560 [details]
ToolBar on windows with and without the patch.

The attached file shows the UI with and without the gerrit change (it's a one-liner just to add the ToolBar to the styling).
Comment 3 Fabio Zadrozny CLA 2015-04-20 19:36:21 EDT 
As a note, I'm not sure how this worked before (seeing the history it seems it worked without this before, but now it doesn't -- at least not in my machine -- did something else change in the meanwhile?)
Comment 5 Lars Vogel CLA 2015-04-21 04:05:38 EDT 
Thanks Fabio, changed merged.
Comment 6 Lars Vogel CLA 2015-04-28 06:21:00 EDT 
Validated in 4.5.0.I20150428-0100