Bug 463223 - Write Javadoc for MModelFragment.merge
Summary: Write Javadoc for MModelFragment.merge
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Steven Spungin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 437958
  Show dependency tree
 
Reported: 2015-03-26 12:07 EDT by Lars Vogel CLA
Modified: 2015-03-30 09:11 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-03-26 12:07:19 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2015-03-26 12:08:40 EDT
        

      






Steven, for Dani to accept the change in Bug 437958, we need to document the merge method via Javadoc. Can you provide a patch for that?

    


    


      



        
          Comment 2
        

        
          Eclipse Genie CLA

        

        
        

        
          2015-03-27 07:32:40 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/44732

    


    

    


      



        
          Comment 4
        

        
          Lars Vogel CLA

        

        
        

        
          2015-03-27 09:28:42 EDT
        

      






Thanks Steven.

    


    


      



        
          Comment 5
        

        
          Dani Megert CLA

        

        
        

        
          2015-03-30 09:04:55 EDT
        

      






I assume

Merges an MModelFragment into an MApplication.

should be:

Merges this MModelFragment into an MApplication.

right?

    


    


      



        
          Comment 6
        

        
          Steven Spungin CLA

        

        
        

        
          2015-03-30 09:06:30 EDT
        

      






That is correct.  Should I change that now, or wait?

    


    


      



        
          Comment 7
        

        
          Eclipse Genie CLA

        

        
        

        
          2015-03-30 09:08:17 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/44841

    


    

    


      



        
          Comment 9
        

        
          Lars Vogel CLA

        

        
        

        
          2015-03-30 09:11:18 EDT
        

      






(In reply to Steven Spungin from comment #6)
> That is correct.  Should I change that now, or wait?

Fixed. 

Thanks Dani for the feedback.