462818 – Model editor erase parent-id in trimContribution

Bug 462818 - Model editor erase parent-id in trimContribution

Summary: Model editor erase parent-id in trimContribution

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	4.5 M7
Assignee:	Olivier Prouvost
QA Contact:

URL:
Whiteboard:
Keywords:	greatfix

Depends on:
Blocks:

Reported:	2015-03-23 04:44 EDT by Loic Faure
Modified:	2015-04-28 14:59 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Loic Faure

2015-03-23 04:44:26 EDT

When I add a trimContribution to the ide and specifie it parent-id, it doesn't appears in the file.
Step to reproduce :
  1. Contributes to the IDE via "org.eclipse.e4.legacy.ide.application" with the featureName "trimContribution"
  2. Adds a trimContribution
  3. Specifies a parent-id like "org.eclipse.ui.main.toolbar"
  4. Add a child like HandledToolItem
  5. Save and close
  6. Reopen the file
The parent-id in the trimContribution disappears, when the file is modified and save then the parent-id is removed.

Comment 1 Lars Vogel

2015-03-23 04:48:39 EDT

Patches are welcome

Comment 2 Lars Vogel

2015-04-21 11:39:19 EDT

Olivier, can you also take this one?

Comment 3 Eclipse Genie

2015-04-22 07:42:59 EDT

New Gerrit change created: https://git.eclipse.org/r/46242

Comment 4 Eclipse Genie

2015-04-22 11:05:39 EDT

Gerrit change https://git.eclipse.org/r/46242 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=48494ee6ab80218b7adf6d96b01a6783ee2500c7

Comment 5 Lars Vogel

2015-04-23 21:55:39 EDT

Thanks Olivier for fixing and Loic for reporting

Comment 6 Lars Vogel

2015-04-28 14:59:49 EDT

Verified in Build id: N20150425-1500