Bug 462606 - [Project Explorer] When switching top-level to working-sets and no working-set is enabled, show the "Select Working Set" dialog
Summary: [Project Explorer] When switching top-level to working-sets and no working-se...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-19 16:09 EDT by Max Rydahl Andersen CLA
Modified: 2015-03-23 08:34 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Rydahl Andersen CLA 2015-03-19 16:09:13 EDT
I have a bunch of projects (~50 or so) and 2 working sets set to match 4 of them.

When selecting top level workingset in package explorer it will let me select which working set to use.

In project explorer I'm not asked and the top level is not changed - its as if no working set existed.

I believe this is a regression from previous versions and since project explorer is the only one supporting nested projects too i'm marking this critical.
Comment 1 Mickael Istria CLA 2015-03-20 09:39:19 EDT
Is this really a regression? How does the same scenario behave with Luna?

My guess is that it's not a bug, but more the fact that if you have no workingset enabled (via "Select Working Sets..."), then the project explorer fails back to showing all projects.
I understand the UI is not optimal, and automatically opening the window to select working sets when none is available and switching to workingsets as top-level elements is a good idea.

I'm marking this as an enhancement request and re-titling this report to make it clearer what's the current state and what's user expectation.
Comment 2 Max Rydahl Andersen CLA 2015-03-20 10:11:26 EDT
well if its not a regression than its a major reason to not use Project Explorer :) 

With package explorer it shows all my workingsets including "Other" for the things not in a working set.

in project explorer I seem to *only* be shown things in the workingset, so its really not a good UX at all even if I was shown the select working set dialog.
Comment 3 Mickael Istria CLA 2015-03-20 12:25:42 EDT
(In reply to Max Rydahl Andersen from comment #2)
> in project explorer I seem to *only* be shown things in the workingset, so
> its really not a good UX at all even if I was shown the select working set
> dialog.

There are 2 things provided by working sets in Project Explorer: organization and filtering.
When enabling some working set (from "Select Working Set"), then you are configuring filters. Only the content of the selected Working Sets is shown.
When setting top-level element as "Working Sets", then you are configuring organization. Top-level element become the selected working sets.

What you describe seems to be that you have selected some working sets, but not made top-level elements to be working sets.
Comment 4 Max Rydahl Andersen CLA 2015-03-20 12:44:32 EDT
No, I have selected all workingsets and enabled the toplevel working sets.

I now only shows the workingsets - what is called Other in Package Explorer just dont seem to exist.

So I'm back to using package explorer as I do not want to be forced to  categorize *everything* in workingsets.
Comment 5 Mickael Istria CLA 2015-03-20 13:52:12 EDT
See bug 266030 for a default working set. I made a patch for it, I think it would help if you could review it and add a vote.

So it this bug a dup of 266030 ?
Comment 6 Max Rydahl Andersen CLA 2015-03-23 08:34:57 EDT
this does look like a duplicate - unfortunately I can't try the patch since its not applying cleanly ;/ can you rebase it ?