Community
Participate
Working Groups
Launch configurations that get saved as a workspace file open by default with the text editor. It would be nice if these could be opened with a real editor instead. This would also be a good alternative to the modal dialog currently used to edit launch configurations.
New Gerrit change created: https://git.eclipse.org/r/43646
New Gerrit change created: https://git.eclipse.org/r/43690
As M6 is at the end, will be looking at it in 4.5 M7. Thanks for the contribution.
I have some more things I'd like to implement around this if it's something that will make it into the release. I've heard there is some controversy around using editors for launch configurations. If the Platform Debug team is on board, here are some of the other things I want to look at implementing: * Launch actions on the editor (much like the PDE product editor) * A view to show all launch configurations (like the left pane in the current dialog) * Integration with the Launch Bar (from CDT), add a preference to open configurations in an editor instead of a dialog.
Patch looks good and does not have any API change.
(In reply to Cole Markham from comment #4) > I have some more things I'd like to implement around this if it's something > that will make it into the release. I've heard there is some controversy > around using editors for launch configurations. If the Platform Debug team > is on board, here are some of the other things I want to look at > implementing: > > * Launch actions on the editor (much like the PDE product editor) > * A view to show all launch configurations (like the left pane in the > current dialog) > * Integration with the Launch Bar (from CDT), add a preference to open > configurations in an editor instead of a dialog. Can you please clarify "I've heard there is some controversy around using editors for launch configurations" !! I don't have the context.
(In reply to Sarika Sinha from comment #6) > (In reply to Cole Markham from comment #4) > > I have some more things I'd like to implement around this if it's something > > that will make it into the release. I've heard there is some controversy > > around using editors for launch configurations. If the Platform Debug team > > is on board, here are some of the other things I want to look at > > implementing: > > > Can you please clarify "I've heard there is some controversy around using > editors for launch configurations" !! I don't have the context. It was just something I heard while asking around at EclipseCon. If the current committers are not opposed to editors, then either I misunderstood or it is in the past. Thanks for looking at this. I realized that I created two separate Gerrit changes which was not my intention. Still trying to figure that process out. Would you like me to combine them?
Yes it will be good to have one gerrit change .
(In reply to Sarika Sinha from comment #6) > Can you please clarify "I've heard there is some controversy around using > editors for launch configurations" !! I don't have the context. Mike, can you remember of anything here?
(In reply to Dani Megert from comment #9) > (In reply to Sarika Sinha from comment #6) > > Can you please clarify "I've heard there is some controversy around using > > editors for launch configurations" !! I don't have the context. > > Mike, can you remember of anything here? Traditionally we have always said "don't edit them except in the launch dialog" - the reason being, if you change the configuration in an editor in a way the launch dialog bits cannot handle, the config is useless - and in some cases will cause the dialog to fail. That said, the proposed fix is very cool, and seems to use the launch dialog logic / UI for the editing, so I think we would be OK (we get the same validation / saving / etc as we do in the dialog itself).
I removed the extra Gerrit change and merged those changes into the original.
Some review comments: From Code : Please add Copyright in new files and update the year for existing files. From Test: 1. If I have editor open in workspace and open the configuration from Run Configurations. I do some changes and Apply, there is no dirty sign in the launch configuration opened in the workspace editor. Save does get enabled. 2. If I have editor open in workspace and open the configuration from Run Configurations. I go to Common Tab and change "Save As" to Local File. file gets removed from Package Explorer but file remains opened in the editor window. I can save and it brings back the file in Package Explorer.
Cole, Do you plan to fix these comments in Mars time frame ?
Moving it to 4.6 for better testing participation.
(In reply to Sarika Sinha from comment #13) > Cole, Do you plan to fix these comments in Mars time frame ? Ping!
(In reply to Sarika Sinha from comment #12) > Some review comments: > From Code : Please add Copyright in new files and update the year for > existing files. > > From Test: > 1. If I have editor open in workspace and open the configuration from Run > Configurations. I do some changes and Apply, there is no dirty sign in the > launch configuration opened in the workspace editor. Save does get enabled. > 2. If I have editor open in workspace and open the configuration from Run > Configurations. I go to Common Tab and change "Save As" to Local File. file > gets removed from Package Explorer but file remains opened in the editor > window. I can save and it brings back the file in Package Explorer. I updated the copyright headers and changed the listeners to handle 1 and 2.
Thanks Cole, I will be looking into it.
Thanks Cole, I see one problem and that is missing error message for invalid inputs for the tabs in the editor.
Moving to 4.7
No work happening on this.
If possible, I would like to take over work on this change, since it fulfills a need I also have. I've locally rebased and fixed some further exceptions related to invalid thread access from the listeners. However, I'm not clear about the policy of taking over "foreign" gerrit changes. Is it okay to submit a new patch set with the original author (if I'm even allowed by gerrit)?
Yes, you can add him as co-author.
