Bug 461766 - [cleanup] T getAdapter(Class<T>) for org.eclipse.ui.workbench
Summary: [cleanup] T getAdapter(Class<T>) for org.eclipse.ui.workbench
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.5 M6   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix, noteworthy
: 463027 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-09 18:12 EDT by Andrey Loskutov CLA
Modified: 2015-03-25 10:19 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2015-03-09 18:12:39 EDT 
While doing cleanup in ide (bug 461762) I observed that org.eclipse.ui.workbench also needs some love (~7200 warnings), but one thing one definitely should do is to change Object getAdapter(Class) to <T> T getAdapter(Class<T>) in org.eclipse.ui.internal.util.Util and org.eclipse.ui.part.WorkbenchPart classes and cleanup all the "unnecessary cast" warnings coming from them and the already generified version of Platform.getAdapterManager().getAdapter().
Comment 1 Eclipse Genie CLA 2015-03-09 18:28:47 EDT 
New Gerrit change created: https://git.eclipse.org/r/43486
Comment 3 Lars Vogel CLA 2015-03-16 07:16:48 EDT 
.
Comment 4 Eclipse Genie CLA 2015-03-19 17:26:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/44213
Comment 5 Andrey Loskutov CLA 2015-03-19 17:29:40 EDT 
Verified in I20150318-2000.
N&N notes for WorkbenchPart.getAdapter(): https://git.eclipse.org/r/44213
Comment 6 Dani Megert CLA 2015-03-25 10:19:40 EDT 
*** Bug 463027 has been marked as a duplicate of this bug. ***