Community
Participate
Working Groups
There have been requests on forums and elsewhere to both control and add to the items shown the part stack context menu.
New Gerrit change created: https://git.eclipse.org/r/43447
The renderer are still considered internal API but +1 for this change. (I'm absolute NOT influenced by our EclipseCon tutorial for which this would also be very handy.)
Generally I'm not against this but I think it would be a lot better if we could provide people access to such a feature without having to role their own renderer.
(In reply to Thomas Schindl from comment #3) > Generally I'm not against this but I think it would be a lot better if we > could provide people access to such a feature without having to role their > own renderer. I agree but I think that would be another bug.
We could consider exposing this menu via the normal extension mechanisms, but I worry that the menu would be flooded by contributions on org.eclipse.ui.popup.any.
(In reply to Brian de Alwis from comment #5) > We could consider exposing this menu via the normal extension mechanisms, > but I worry that the menu would be flooded by contributions on > org.eclipse.ui.popup.any. We could extend the model to allow model menu contributions for MPartStack elements.
Brian, I move this to M7, if you still plan to commit this for M6, please move it back.
Sorry, this slipped through the cracks: as it's just moving some code into a new method, if you're ok with it for M6 then I'll commit it tonight.
(In reply to Brian de Alwis from comment #8) > Sorry, this slipped through the cracks: as it's just moving some code into a > new method, if you're ok with it for M6 then I'll commit it tonight. If there is no pressing need, I suggest to wait for early M7.
Seeking PMC approval since this patch introduces a new protected method "populateTabMenu(Menu, MPart)" intended to be for subclasses on StackRenderer, and exposes a previously-private method "isClosable(MPart)" as it's useful for these subclasses. Even with a model-based solution as per Tom and Lars' comments above, this separation is still useful to provide RCP products the ability to customize the part stack context menus; I know of one commercial product that wants this ability.
(In reply to Brian de Alwis from comment #10) > Seeking PMC approval since this patch introduces a new protected method > "populateTabMenu(Menu, MPart)" intended to be for subclasses on > StackRenderer, and exposes a previously-private method "isClosable(MPart)" > as it's useful for these subclasses. AFAIK the renderer are not API, so PMC approval should not necessary. See the MANIFEST.MF of org.eclipse.e4.ui.workbench.renderers.swt. I remove the PMC flag, please add it again, if I oversee something.
(In reply to Lars Vogel from comment #11) > AFAIK the renderer are not API, so PMC approval should not necessary. See > the MANIFEST.MF of org.eclipse.e4.ui.workbench.renderers.swt. I remove the > PMC flag, please add it again, if I oversee something. Oops, thanks for pointing that out! Great, I'll commit shortly.
Gerrit change https://git.eclipse.org/r/43447 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4f4d9e9cee1e6a9b1f6af1d0e9c79d37217beb09
Fixed for M7
Reopening to track the model-based solution.
I suggest to open a new bug for the possible model extension and to mark this one as fixed.
Will do.
Verified by inspection in I20150428-0100
Is there any progress on the model extension for this? Thanks
No sorry. Please discuss on bug 463124.
