Bug 461026 - Translation for tool and menu item not working if command uses translation
Summary: Translation for tool and menu item not working if command uses translation
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 8
: P3 normal (vote)
Target Milestone: 4.5 M6   Edit
Assignee: Dirk Fauth CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2015-02-27 04:13 EST by Lars Vogel CLA
Modified: 2015-03-02 05:20 EST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-02-27 04:13:00 EST 
The command uses translation for example %commands.save

The HandledToolItem refers to the command (without defining its text again, Label is empty) and without defining a icon.

-> The key is not replaced.
Comment 1 Lars Vogel CLA 2015-02-27 04:13:39 EST 
Dirk, can you have a look?
Comment 2 Lars Vogel CLA 2015-02-27 04:21:40 EST 
Same for menu entries without label
Comment 3 Dirk Fauth CLA 2015-02-27 04:33:07 EST 
Sorry, I don't understand that.

If I create a menu entry without a label, e.g. HandledMenuItem in a File menu in the main menu, then nothing will be shown. I am not aware of a feature that automatically sets the name of the command as label of a menu item.

I'm testing on Windows 7 and an empty menu entry is shown in that case. AFAIK you always have to specify the label of a menu or tool item.
Comment 4 Lars Vogel CLA 2015-02-27 04:37:33 EST 
(In reply to Dirk Fauth from comment #3)
> Sorry, I don't understand that.
> 
> If I create a menu entry without a label, e.g. HandledMenuItem in a File
> menu in the main menu, then nothing will be shown. I am not aware of a
> feature that automatically sets the name of the command as label of a menu
> item.
> 
> I'm testing on Windows 7 and an empty menu entry is shown in that case.
> AFAIK you always have to specify the label of a menu or tool item.

Without translation the text from the command is used, if you do not specify a text on the menu / toolitem.
Comment 5 Eclipse Genie CLA 2015-02-27 06:03:40 EST 
New Gerrit change created: https://git.eclipse.org/r/42888
Comment 7 Lars Vogel CLA 2015-02-27 08:11:37 EST 
Thanks Dirk, looks good.