Bug 460048 - Move platform runtime plugins to Java 1.7 BREE
Summary: Move platform runtime plugins to Java 1.7 BREE
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2015-02-16 14:06 EST by Andrey Loskutov CLA
Modified: 2015-04-28 06:02 EDT (History)
4 users (show)

See Also:
daniel_megert: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2015-02-16 14:06:01 EST 
Followup on bug 459373 and bug 459399 comment 14.
The plugins below still want to have JRE strictly compatible with 1.4. They should be moved on 1.6:

org.eclipse.core.expressions.tests
org.eclipse.core.expressions
org.eclipse.core.contenttype
Comment 1 Lars Vogel CLA 2015-02-16 14:11:00 EST 
I'm also fine with moving them to Java 7. The only requirement is to not create new warnings in the build.
Comment 2 Eclipse Genie CLA 2015-02-17 18:23:12 EST 
New Gerrit change created: https://git.eclipse.org/r/42085
Comment 3 Eclipse Genie CLA 2015-02-17 18:23:14 EST 
New Gerrit change created: https://git.eclipse.org/r/42086

WARNING: this patchset contains 1355 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 4 Andrey Loskutov CLA 2015-02-17 18:25:21 EST 
I've pushed two reviews, please consider them as work in progress - it is the first time I try to convert projects semi-automatically.
Comment 5 Eclipse Genie CLA 2015-03-08 01:18:28 EST 
New Gerrit change created: https://git.eclipse.org/r/43354
Comment 6 Eclipse Genie CLA 2015-03-08 01:27:31 EST 
New Gerrit change created: https://git.eclipse.org/r/43355
Comment 7 Eclipse Genie CLA 2015-03-08 01:32:53 EST 
New Gerrit change created: https://git.eclipse.org/r/43356
Comment 8 Eclipse Genie CLA 2015-03-08 01:42:45 EST 
New Gerrit change created: https://git.eclipse.org/r/43358
Comment 9 Eclipse Genie CLA 2015-03-08 01:47:26 EST 
New Gerrit change created: https://git.eclipse.org/r/43359
Comment 10 Eclipse Genie CLA 2015-03-08 01:53:48 EST 
New Gerrit change created: https://git.eclipse.org/r/43360
Comment 11 Eclipse Genie CLA 2015-03-08 01:55:49 EST 
New Gerrit change created: https://git.eclipse.org/r/43361
Comment 12 Eclipse Genie CLA 2015-03-08 03:01:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/43362
Comment 13 Eclipse Genie CLA 2015-03-08 03:02:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/43363
Comment 14 Eclipse Genie CLA 2015-03-08 03:04:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/43364
Comment 15 Eclipse Genie CLA 2015-03-08 03:25:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/43365
Comment 18 Eclipse Genie CLA 2015-03-09 04:59:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/43389
Comment 22 Eclipse Genie CLA 2015-03-09 15:23:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/43466
Comment 26 Tobias Oberlies CLA 2015-03-30 06:51:46 EDT 
(In reply to Lars Vogel from comment #1)
> I'm also fine with moving them to Java 7. The only requirement is to not
> create new warnings in the build.

Was this the entire discussion that lead to the decision to change the platform to require Java 7? Or was there a broader discussion around this?
Comment 27 Lars Vogel CLA 2015-03-30 07:29:57 EDT 
(In reply to Tobias Oberlies from comment #26)
> (In reply to Lars Vogel from comment #1)
> > I'm also fine with moving them to Java 7. The only requirement is to not
> > create new warnings in the build.
> 
> Was this the entire discussion that lead to the decision to change the
> platform to require Java 7? Or was there a broader discussion around this?

IIRC the change to require Java 7 for the platform was triggered by the requirement of Jetty. Afterwards the projects started to move to Java 7. You find individual bugs reports for these moves.
Comment 28 Tobias Oberlies CLA 2015-03-30 11:15:44 EDT 
(In reply to comment #27)
> IIRC the change to require Java 7 for the platform was triggered by the
> requirement of Jetty. Afterwards the projects started to move to Java 7. You
> find individual bugs reports for these moves.
This wouldn't imply that all of the platform has to use Java 7 - e.g. to support Eclipse embedders like Tycho which don't embed the Eclipse help system.

But I just realized that JDT has also updated to Java 7 [1] so it is anyway clear that Tycho needs to update the required Java version. So I no longer have any concerns regarding this change :-)

[1] https://www.eclipse.org/projects/project-plan.php?projectid=eclipse#appendix
Comment 34 Eclipse Genie CLA 2015-04-05 15:30:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/45309
Comment 36 Eclipse Genie CLA 2015-04-05 18:16:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/45310
Comment 37 Eclipse Genie CLA 2015-04-05 18:36:24 EDT 
New Gerrit change created: https://git.eclipse.org/r/45311
Comment 40 Eclipse Genie CLA 2015-04-06 04:03:36 EDT 
New Gerrit change created: https://git.eclipse.org/r/45312
Comment 42 Eclipse Genie CLA 2015-04-06 08:08:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/45324
Comment 44 Andrey Loskutov CLA 2015-04-06 08:20:47 EDT 
Closing this one as fixed. Remaining two runtime projects should be removed via bug 394739:
org.eclipse.core.runtime.compatibility
org.eclipse.core.runtime.compatibility.registry
Comment 45 Dani Megert CLA 2015-04-09 04:24:02 EDT 
This is considered an API change that happened after the API freeze. Such a change needs PMC approval after M7. The PMC will discuss it in next week's meeting. Depending on the outcome, this will have to be reverted.

Also note, that the bundle minor version has to be increased (if not yet done in the current release).
Comment 46 Dani Megert CLA 2015-04-10 03:41:14 EDT 
(In reply to Dani Megert from comment #45)
> ... Such a change needs PMC approval after M7.

Sorry, it's after M6, not M7.
Comment 47 Dani Megert CLA 2015-04-21 10:44:43 EDT 
(In reply to Dani Megert from comment #45)
> This is considered an API change that happened after the API freeze. Such a
> change needs PMC approval after M7. The PMC will discuss it in next week's
> meeting. Depending on the outcome, this will have to be reverted.

The decision was to not allow this after M6 and revert where it's easy to do so. In this particular case, a lot of other bundles were already moved up before M6 plus, some of the changes came along with real code changes. Therefore I won't revert anything here.

Note that the following has once again been confirmed by the PMC and also applies for 4.6:
"
Rule has always been "we move up when there's a reason to move up". We won't move up without reason. 
"
This means, a BREE change must always come with a "real" change that actually requires to change the BREE (use multi-catch, generify, use nio APIs, etc.).


> Also note, that the bundle minor version has to be increased (if not yet
> done in the current release).

I'm reopening this bug since I've seen at least one case where the bundle's minor version has not been increased correctly. Please check all changed bundles for the correct version number and provide a patch for those who need to be updated.

Thanks.
Comment 48 Eclipse Genie CLA 2015-04-21 18:14:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/46210
Comment 50 Lars Vogel CLA 2015-04-22 02:31:10 EDT 
Thanks Andrey for the bundle increase, Dani please reopen if something is missing.
Comment 51 Dani Megert CLA 2015-04-22 04:42:47 EDT 
(In reply to Lars Vogel from comment #50)
> Thanks Andrey for the bundle increase, Dani please reopen if something is
> missing.

Thanks guys!
Comment 52 Lars Vogel CLA 2015-04-28 06:02:54 EDT 
.