Bug 459641 - [CPD] disabled/enabled state not reflected correctly on Action Set Availability page
Summary: [CPD] disabled/enabled state not reflected correctly on Action Set Availabili...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.5 M6   Edit
Assignee: Noopur Gupta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 420956
  Show dependency tree
 
Reported: 2015-02-11 06:07 EST by Noopur Gupta CLA
Modified: 2015-04-15 11:30 EDT (History)
3 users (show)

See Also:

Attachments
Screenshot showing the issue (238.24 KB, image/png)
2015-02-17 01:47 EST, Noopur Gupta CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2015-02-11 06:07:11 EST 
Eclipse Mars M5 - Go to Action Set Availability page on CPD.

Toggle the check state of a disabled/enabled action set. The updated state (gray icon and text) is not reflected on the Menubar and Toolbar details section until the state is toggled again or the action set is selected again.
Comment 1 Eclipse Genie CLA 2015-02-16 07:30:48 EST 
New Gerrit change created: https://git.eclipse.org/r/41922
Comment 2 Andrey Loskutov CLA 2015-02-16 16:32:18 EST 
Hmm, I don't see the issue on HEAD (or the effect of the change) on Linux - or it is too subtle? Noopur, can you please attach a screenshot where one has to see differences?
Comment 3 Noopur Gupta CLA 2015-02-17 01:47:56 EST 
Created attachment 250851 [details]
Screenshot showing the issue

Screenshot shows the issue on HEAD on Windows 7.
Comment 4 Andrey Loskutov CLA 2015-02-17 02:00:12 EST 
(In reply to Noopur Gupta from comment #3)
> Created attachment 250851 [details]
> Screenshot showing the issue
> 
> Screenshot shows the issue on HEAD on Windows 7.

Wow, that's crazy. As the fix didn't changed anything on my Linux GTK2 Eclipse (it was just OK), I think your patch is good.
Comment 5 Eclipse Genie CLA 2015-02-17 07:32:24 EST 
New Gerrit change created: https://git.eclipse.org/r/42031
Comment 6 Noopur Gupta CLA 2015-02-17 07:41:00 EST 
(In reply to Eclipse Genie from comment #5)
> New Gerrit change created: https://git.eclipse.org/r/42031

This was supposed to be a new patch set for the previous gerrit request.
"actionSetAvailabilityTable.refresh(this);" did not update the action set that was toggled. Hence, changed to "actionSetAvailabilityTable.refresh();".

(In reply to Andrey Loskutov from comment #4)
> As the fix didn't changed anything on my Linux GTK2
> Eclipse (it was just OK), I think your patch is good.

Probably there is some auto-refresh happening on the tree structures in Linux?
The new patch should reflect the change in the action set state.
Comment 9 Dani Megert CLA 2015-02-17 11:50:24 EST 
.
Comment 10 Eclipse Genie CLA 2015-04-15 04:15:14 EDT 
New Gerrit change created: https://git.eclipse.org/r/45841
Comment 11 Eclipse Genie CLA 2015-04-15 04:15:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/45842