Bug 459578 - [CSS] Add styling for "Presentation" mode
Summary: [CSS] Add styling for "Presentation" mode
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M6   Edit
Assignee: Simon Scholz CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix, noteworthy
Depends on:
Blocks: 463109
  Show dependency tree
 
Reported: 2015-02-10 11:42 EST by Lars Vogel CLA
Modified: 2015-06-16 01:06 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2015-02-10 11:42:20 EST
We (as the Eclipse developer community) give frequently presentations with the Eclipse IDE and have to fiddle with the text size settings. 

I suggest to add a "Presentation" CSS file which adjust the text size to "16", a value I think is good for a delivering a presentation.

Any other preference value which comes to mind? Please let me know.
Comment 1 Lars Vogel CLA 2015-02-10 12:04:15 EST
Simon, can you add the CSS to the org.eclipse.ui.themes plug-in? I suggest to import the existing platform specific stylesheet.
Comment 2 Eclipse Genie CLA 2015-02-17 09:26:27 EST
New Gerrit change created: https://git.eclipse.org/r/42039
Comment 3 Simon Scholz CLA 2015-02-17 09:28:53 EST
Just uploaded patch is just for GTK. I also need the preference values for other OS, like Windows and Mac.
Comment 4 Lars Vogel CLA 2015-02-19 17:11:16 EST
Stefan, what is the value on a Mac if you set the text size to 16?

On Linux we have 'org.eclipse.jface.textfont=1|Monospace|16.0|0|GTK|1|'

You can use the preference spy to find that value: http://preferencespy.vogella.com/
Comment 5 Stefan Winkler CLA 2015-02-19 17:52:38 EST
Here's what the preference on Mac OS X looks like:

org.eclipse.jface.textfont=1|Monaco|16.0|0|COCOA|1|Monaco
Comment 6 Simon Scholz CLA 2015-02-20 03:40:43 EST
The font value on Windows 7 is this:

1|Consolas|15.75|0|WINDOWS|1|-21|0|0|0|400|0|0|0|0|3|2|1|49|Consolas;

Looks a bit longer than on linux or mac.
Comment 7 Simon Scholz CLA 2015-03-02 04:45:13 EST
I just uploaded a patch for mac and windows as well.

Can someone test these themes?

Thanks in advance.
Comment 9 Lars Vogel CLA 2015-03-07 22:50:59 EST
(In reply to Simon Scholz from comment #7)
> Can someone test these themes?

Thanks Simon, looks fine for me on Linux. Could you provide a N&N for this change?
Comment 10 Lars Vogel CLA 2015-03-07 22:51:10 EST
.
Comment 11 Lars Vogel CLA 2015-03-10 22:08:44 EDT
In the Build id: I20150305-1200 I do not see the new themes. @Simon, please have a look.
Comment 12 Simon Scholz CLA 2015-03-13 05:50:24 EDT
The theme is available and can be set.

Currently we have a different issue concerning the editor styling, where the presentationmode is also affected: https://bugs.eclipse.org/bugs/show_bug.cgi?id=462056

But I change this bug to resolved fixed again
Comment 13 Lars Vogel CLA 2015-03-16 19:52:36 EDT
Verified in 4.5.0.N20150315-1630
Comment 14 Klaus Klaus CLA 2015-03-27 18:14:33 EDT
The Presentationmode has an side effect (to me this is an bug):

Tested with Mars 4.5M6 on Windows.

Steps:

Open a new workspace

create a file and add some text

change the font-type and or size of the font (Windows->Preferences->General->Appearance->Color and Fonts->Basic->Text Font).

switch to presentation mode (Font size increases)

switch back to the default Appearance "Windows"

The font and size will immediately reseted to the default font and size! 
The original setting in this Appearance is lost :-(

Switching to a Appearance A should not change the settings of Appearance B...
Comment 15 Lars Vogel CLA 2015-03-31 14:41:30 EDT
(In reply to Klaus Mr from comment #14)
> The Presentationmode has an side effect (to me this is an bug):
> 
> Tested with Mars 4.5M6 on Windows.
> 
> Steps:
> 
> Open a new workspace
> 
> create a file and add some text
> 
> change the font-type and or size of the font
> (Windows->Preferences->General->Appearance->Color and Fonts->Basic->Text
> Font).

Sounds like Bug 441135 or Bug 435512. Please open a new bug for this issue with your example description.
Comment 16 Stephan Herrmann CLA 2015-06-15 18:51:54 EDT
Apparently this feature has been withdrawn via bug 466080. I think the correct resolution would then be WONTFIX.
Comment 17 Lars Vogel CLA 2015-06-16 01:06:02 EDT
This feature was reverted, for Neon we are planning to provide shortcuts to increase font size in the editor. 

Thanks Stephan for the reminder of house keeping.