Bug 459412 - [Graphics] Need High Resolution Icons
Summary: [Graphics] Need High Resolution Icons
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC All
: P3 enhancement with 1 vote (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Tony McCrary CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on: 426025
Blocks: 421383 479614
  Show dependency tree
 
Reported: 2015-02-09 03:56 EST by Sravan Kumar Lakkimsetti CLA
Modified: 2016-07-08 03:08 EDT (History)
13 users (show)

See Also:


Attachments
eclipse-png-highdpi.zip (4.05 MB, application/zip)
2015-04-26 12:20 EDT, Markus Keller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sravan Kumar Lakkimsetti CLA 2015-02-09 03:56:29 EST
For developing the Bug 421383, We need high resoulution icons. The sizes required are 16x16, 24x24 and 32x32.
Comment 1 Dani Megert CLA 2015-02-09 10:03:01 EST
(In reply to Sravan Kumar Lakkimsetti from comment #0)
> For developing the Bug 421383, We need high resoulution icons. The sizes
> required are 16x16, 24x24 and 32x32.

We first need to have a POC where to put this, how to name those, etc. Before that we should wait with this request.
Comment 2 Marcus Hirt CLA 2015-02-09 10:53:28 EST
An established naming convention is not required to start with the artwork, is it? If the intended release for supporting high DPI screens is 4.5.0, we'll need to hit the ground running once the support (Bug 421383) is there. I'll personally try to start a project for the Java Mission Control icons right away.
Comment 3 Dani Megert CLA 2015-02-09 11:29:42 EST
(In reply to Marcus Hirt from comment #2)
> An established naming convention is not required to start with the artwork,
> is it?

Naming is not the only thing. We have way too many icons to provide. Using the proposed solution we need to see which ones still look bad and give them the priority. Of course, if you want to start providing new icons right now, that's perfectly fine.
Comment 4 Lars Vogel CLA 2015-02-09 11:47:35 EST
We already have svg version of most platform, PDE and JDT icons thanks to Tony. Tony also created a Maven Mojo
Comment 5 Lars Vogel CLA 2015-02-09 11:51:10 EST
Tony also created a Maven Mojo to generated different sized png file from these svg versions. These icons are currently hosted in the eclipse.platform.ui repo but we are planning to move them to a more general repository. See Bug 459291 and Bug 422139.

I think JDT still needs to review their icons, see Bug 426025.

So in summary, you already generate your high-resolution icons. See README.md in eclipse.platform.ui/bundles/org.eclipse.ui.images.rendere
Comment 6 Marcus Hirt CLA 2015-02-09 12:13:30 EST
Nice! Well, you're lucky then. We (JMC) do not have any of our (non-eclipse) icons in SVG. The JMC team desperately needs a Tony. How far along is the cloning tech? ;)
Comment 7 Lars Vogel CLA 2015-03-30 07:36:20 EDT
AFAIK Markus works on this via Bug 382972.

@Markus, you can eclipse.platform.ui/bundles/org.eclipse.ui.images.renderer to generated other resolutions of the icons via Maven from org.eclipse.ui.images. 

See eclipse.platform.ui/bundles/org.eclipse.ui.images.renderer/README.md for the parameters.
Comment 8 Markus Keller CLA 2015-04-26 12:20:39 EDT
Created attachment 252773 [details]
eclipse-png-highdpi.zip

Zip of fragment bundles that add @2x and @1.5x version of icons.

Generated from eclipse.platform.ui/bundles/org.eclipse.ui.images on OS X 10.10 with command:
mvn -Declipse.svg.scale=1.5 -Declipse.svg.renderthreads=1 org.eclipse.ui:org.eclipse.ui.images.renderer:render-icons

To test them, you currently need to enable high-dpi in JFace via debug options:

# Switch URLImageDescriptor to load images using the "@2x" convention for high-dpi
org.eclipse.jface/debug/loadURLImageDescriptor2x=true

# Always load the .png image of the "@2x" version, even if the original image was a .gif.
org.eclipse.jface/debug/loadURLImageDescriptor2xPngForGif=true


Note that some icon lookups are still hardcoded to resolve normal-resolution icons too early, so that the URLImageDescriptor doesn't have a chance to use the @*x version when SWT requests such a high-dpi version.

The way to fix that is shown e.g. in master of org.eclipse.ui.plugin.AbstractUIPlugin#imageDescriptorFromPlugin(String, String).
Comment 9 Lars Vogel CLA 2015-05-06 16:11:37 EDT
We have now svg for the important platform projects and a way to generate different sized png for it. Marking as fixed. Please open more specific bugs, if you need icons for additional platform components or have other issues.
Comment 10 Lars Vogel CLA 2015-05-06 16:12:45 EDT
Kudos to Tony for putting in the work for creating the svg icons and a Maven Mojo for generating differently sized icons from them.
Comment 11 Matthias Becker CLA 2015-09-23 04:00:34 EDT
(In reply to Markus Keller from comment #8)
> Created attachment 252773 [details]
> eclipse-png-highdpi.zip
> 
> Zip of fragment bundles that add @2x and @1.5x version of icons.
> 
> Generated from eclipse.platform.ui/bundles/org.eclipse.ui.images on OS X
> 10.10 with command:
> mvn -Declipse.svg.scale=1.5 -Declipse.svg.renderthreads=1
> org.eclipse.ui:org.eclipse.ui.images.renderer:render-icons
> 
> To test them, you currently need to enable high-dpi in JFace via debug
> options:
> 
> # Switch URLImageDescriptor to load images using the "@2x" convention for
> high-dpi
> org.eclipse.jface/debug/loadURLImageDescriptor2x=true
> 
> # Always load the .png image of the "@2x" version, even if the original
> image was a .gif.
> org.eclipse.jface/debug/loadURLImageDescriptor2xPngForGif=true
> 
> 
> Note that some icon lookups are still hardcoded to resolve normal-resolution
> icons too early, so that the URLImageDescriptor doesn't have a chance to use
> the @*x version when SWT requests such a high-dpi version.
> 
> The way to fix that is shown e.g. in master of
> org.eclipse.ui.plugin.AbstractUIPlugin#imageDescriptorFromPlugin(String,
> String).

Is that debug switch still needed? When will the support for multiple resolution icons be available? Will it always be needed to supply the higher resolution icons via a fragment or can they simply be put into the host bundle next to the "low resolution" icons?
Comment 12 John Kozlov CLA 2016-04-15 05:21:04 EDT
If we already have high resolution icons, why doesn't Eclipse 4.5 have them yet??