Bug 458662 - support Gerrit 2.10
Summary: support Gerrit 2.10
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal with 1 vote (vote)
Target Milestone: 2.7   Edit
Assignee: Nicholas Folk CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, greatfix, helpwanted, noteworthy
: 463587 (view as bug list)
Depends on: 458765
Blocks:
  Show dependency tree
 
Reported: 2015-01-28 12:28 EST by Sam Davis CLA
Modified: 2015-06-24 16:25 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Sam Davis CLA 2015-03-02 13:54:26 EST
Bug 461226 may be related.
Comment 2 Sam Davis CLA 2015-03-06 14:06:49 EST
Moving to the next release as we won't have time to implement this for 3.15
Comment 3 Sam Davis CLA 2015-04-15 19:13:45 EDT
In order to make supporting new Gerrit versions feasible, I think we will have to drop support for versions older than 2.9.
Comment 4 Steffen Pingel CLA 2015-04-15 19:34:38 EDT
(In reply to comment #3)
> In order to make supporting new Gerrit versions feasible, I think we will have
> to drop support for versions older than 2.9.

+1
Comment 5 Corneliud Dirmeier CLA 2015-04-26 18:08:20 EDT
+1

And please document anywhere prominent which version of gerrit is supportet! I just installed a new gerrit. Now I found out that only <=2.9 is supportet. Current version is 2.11!
Comment 6 Sam Davis CLA 2015-04-30 14:51:21 EDT
Gerrit 2.10 is now supported. Support for versions older than 2.9 has been removed and the connector will no longer work with those versions. Nice work Nick!

(In reply to comment #5)
> +1
> 
> And please document anywhere prominent which version of gerrit is supportet! I
> just installed a new gerrit. Now I found out that only <=2.9 is supportet.
> Current version is 2.11!

We used to put this information in the label of the connector that is shown when you add a repository, but we found that it was too hard to keep up to date. But if you try to validate a connection to an unsupported version you will get a warning. Do you have any suggestions on where else we could document the supported version (that you would have seen it)?

FYI, it looks like Gerrit 2.11 should be supported very soon (bug 465132).
Comment 7 Sam Davis CLA 2015-04-30 14:59:35 EDT
I've pushed a change to add this back to the connector label. It should be easy to keep up to date now that we have test coverage for this.

46934: 458662: add supported versions to connector label [Ie18813c3]
https://git.eclipse.org/r/#/c/46934/
Comment 8 Corneliud Dirmeier CLA 2015-04-30 15:40:36 EDT
Thank you so far.

(In reply to Sam Davis from comment #6)
> Do you have any suggestions on where else we could
> document the supported version (that you would have seen it)?
> 

I suggest to document the currently supported versions at least in the new and notworthy of mylyn (http://eclipse.org/mylyn/new/).

BTW: I do not exactly know how mylyn project and gerrit connector correlates but I find nearly no documentation about the gerrit connector when I look at http://eclipse.org/mylyn/. Maybe you could add a section with some information here. Or at least a link to the current version.
Comment 9 Sam Davis CLA 2015-04-30 16:34:42 EDT
(In reply to comment #8)
> Thank you so far.
> 
> (In reply to Sam Davis from comment #6)
> > Do you have any suggestions on where else we could
> > document the supported version (that you would have seen it)?
> >
> 
> I suggest to document the currently supported versions at least in the new and
> notworthy of mylyn (http://eclipse.org/mylyn/new/).

That's a good idea. Done!
Comment 10 Corneliud Dirmeier CLA 2015-05-01 15:13:45 EDT
> > I suggest to document the currently supported versions at least in the new and
> > notworthy of mylyn (http://eclipse.org/mylyn/new/).
> 
> That's a good idea. Done!

Thanks, look good.
Comment 11 Sam Davis CLA 2015-05-01 19:51:43 EDT
*** Bug 463587 has been marked as a duplicate of this bug. ***