Bug 4586 - Use checkWidget() more often (1G80URQ)
Summary: Use checkWidget() more often (1G80URQ)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-11 14:19 EDT by Carolyn MacLeod CLA
Modified: 2002-05-16 01:45 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2001-10-11 14:19:25 EDT 
In subclasses of Widget, there are 577 occurrences of the 2 lines of code:
		if (!isValidThread ()) error (SWT.ERROR_THREAD_INVALID_ACCESS);
		if (!isValidWidget ()) error (SWT.ERROR_WIDGET_DISPOSED);

	Consider replacing these with:
		checkWidget ();

NOTES:

SN (2/5/01 5:06:31 PM)
	You are right but it's too much work to change now, especially if we are
	going to revisit these methods to support threads better in SWT.
Comment 1 DJ Houghton CLA 2001-10-29 16:23:34 EST 
PRODUCT VERSION:
	SWT 0.057
Comment 2 Carolyn MacLeod CLA 2002-05-16 01:45:41 EDT 
Marking fixed - this has mostly been done.