Bug 458285 - Auto assist shouldn't start if identifier is empty
Summary: Auto assist shouldn't start if identifier is empty
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2015-01-23 12:14 EST by Dawid Pakula CLA
Modified: 2020-05-14 13:28 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2015-01-23 12:14:52 EST 
If user write:
new |
new \|
throw new |
throw new \|
\|

and similar, we shouldn't autorun content assist. On large workspace this always will be performance killer (for example ~10k types +  ~10k namespaces + lot of const and functions) and will froze an editor.

Off course ctrl+space should still work.

What you think?
Comment 1 Dawid Pakula CLA 2015-01-24 09:24:49 EST 
Simple patch: https://git.eclipse.org/r/40307

This patch disable auto activation popup if user:

1. Put white space character (space, tab, what ever)
2. Put "\" and if before him is white character
Comment 2 Thierry BLIND CLA 2015-01-24 12:29:35 EST 
@Dawid, you're right, it will help a lot, it's not uncommon to have big workspaces ;)
Comment 3 Dawid Pakula CLA 2015-01-25 17:16:25 EST 
Michal also agree (see patch comments)

Merged: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=fbb6699f067f05e20b620241978474424a0c4b33
Comment 4 Sylvia Tancheva CLA 2015-02-10 04:59:43 EST 
Verified - no auto-activation after space or \. Closing