Community
Participate
Working Groups
testShowView() junit.framework.AssertionFailedError: Warning: Label {Use F2 to display the description for a selected view.} Actual Width -> 0 Recommended Width -> 350 org.eclipse.ui.tests.api.IWorkbenchPageTest testBug76285(org.eclipse.ui.tests.api.IWorkbenchPageTest) junit.framework.AssertionFailedError: expected:<5> but was:<6> I do not see these failures on your build server, so it might that we again have an GTK3 issue. Paul could you confirm that these tests pass fine on your Redhat installation?
To test this start org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/UiTestSuite.java
UiTestSuite passes for me on RHEL 6.5 PW
Not sure if relevant, but: FYI: there was a single test 'error' in SWT's TabFolder when ran on GTK3 that was due to a change introduced in: Bug 454936 - [GTK3] DND does not work on TabFolder I fixed the 'error' this morning: https://git.eclipse.org/r/#/c/40258/ But there are also 3 failures in Color & Text if SWT is ran under GTK3 still..
(In reply to Paul Webster from comment #2) > UiTestSuite passes for me on RHEL 6.5 > PW Moving to SWT for investigation, maybe similar to Bug 457464
I still have errors if I run the test with GTK3. Can this be evaluated by the SWT team?
Would you please share the exact gtk 3.x version you have and the failing tests?
I am trying the reproduce this. Configuration Ubuntu 14 with GTK 3.10. this is the failed test UiTestSuite org.eclipse.ui.tests.UiTestSuite org.eclipse.ui.tests.dialogs.UIAutomatedSuite org.eclipse.ui.tests.dialogs.UIDialogsAuto testShowView(org.eclipse.ui.tests.dialogs.UIDialogsAuto) I did some analysis on this. Looks like the label widget is not realized when the get size is called. Most likely the problem could be in Shell.setVisible(). We use gtk_widget_show() api to show the widget. This will show the container immediately and takes time to show its contents. There are two ways to resolve this 1. Not to hide the label during the creation 2. Use gtk_widget_show_all() here. This doesnot look like a good option When I changed this to gtk_widget_show_all there is a difference in actual width and recommended width and all the text became right aligned. Need to investigate further on this. Moving to M4
Hi Lars, I reviewed this bug. I found the following code in createDialogArea method of class org.eclipse.ui.internal.dialogs.ShowViewDialog // Use F2... label descriptionHint = new Label(composite, SWT.WRAP); descriptionHint.setText(WorkbenchMessages.ShowView_selectViewHelp); descriptionHint.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false)); descriptionHint.setVisible(false); here the label is created as invisible. From https://lwn.net/Articles/544395/ : Invisible widgets now return a size of 0x0. I think this is causing the test failure in GTK3. Is there a reason why this label is created as invisible? Thanks Sravan
Hi lars, do you have any update on this. Moving to 4.6 Thanks Sravan
Hi Lars, I think this gets fixed by Bug 465280. Can you please test this again? Thanks Sravan
(In reply to Sravan Kumar Lakkimsetti from comment #10) > I think this gets fixed by Bug 465280. Can you please test this again? Sorry, didn't see your comment 8. I will test again with 4.6.0.N20151203-2000.
(In reply to Lars Vogel from comment #11) > Sorry, didn't see your comment 8. I will test again with > 4.6.0.N20151203-2000. Fix is not yet in 4.6.0.N20151203-2000, so I have to wait for the next I-Build.
(In reply to Lars Vogel from comment #12) > (In reply to Lars Vogel from comment #11) > > Sorry, didn't see your comment 8. I will test again with > > 4.6.0.N20151203-2000. > Fix is not yet in 4.6.0.N20151203-2000, so I have to wait for the next > I-Build. The bug fix went in today. So you can check this with tonight's N build/I-build
(In reply to Sravan Kumar Lakkimsetti from comment #13) > (In reply to Lars Vogel from comment #12) > > (In reply to Lars Vogel from comment #11) > > > Sorry, didn't see your comment 8. I will test again with > > > 4.6.0.N20151203-2000. > > Fix is not yet in 4.6.0.N20151203-2000, so I have to wait for the next > > I-Build. > > > The bug fix went in today. So you can check this with tonight's N > build/I-build Fix for bug 465280 was reverted from M4, so I'm moving this bug also to M5.
since the dependent bug 465280 is moved to 4.7, moving this to 4.7
This bug might be related to: 497330: [Gtk3] Platform.ui test failures on Gtk https://bugs.eclipse.org/bugs/show_bug.cgi?id=497330
Moving to 4.8.
All tests are working. Closing. If/when new failure appear please open new bugs to handle them.
