Bug 458029 - [Commands] HandlerServiceImpl uses statics to build the execution context which fails in multi-user Envs like RAP
Summary: [Commands] HandlerServiceImpl uses statics to build the execution context whi...
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-21 06:48 EST by Thomas Schindl CLA
Modified: 2019-08-08 15:19 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2015-01-21 06:48:12 EST 
The static methods are:
* push(IEclipseContext,IEclipseContext)
* pop()

There are the following solutions:
* we make those methods instance methods and store informations in MApplication.getTransientData()
* we modify the methods to accept an MApplication element so we get
  * push(MApplication app, IEclipseContext,IEclipseContext)
  * pop(MApplication app)

I'm marking this as a major issue because it blocks the implementation of e4 on RAP
Comment 1 Thomas Schindl CLA 2015-01-21 06:48:33 EST 
Oh the class in question is HandlerServiceImpl
Comment 2 Thomas Schindl CLA 2015-01-21 06:53:31 EST 
ok - we don't have access to MApplication in e4.core.commands
Comment 3 Thomas Schindl CLA 2015-01-22 03:25:24 EST 
I pushed an implementation as https://git.eclipse.org/r/40096
Comment 4 Thomas Schindl CLA 2015-01-22 04:31:40 EST 
grr to dumb to use gerrit - https://git.eclipse.org/r/40098
Comment 5 Eclipse Genie CLA 2018-11-24 09:07:50 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Lars Vogel CLA 2019-08-08 15:19:05 EDT 
This bug has been marked with as "stalebug" for some time now. I mark this bug as "worksforme" to indicate that no work is planned here. 

If this bug is still relevant for the latest release, please reopen the bug and remote the "stalebug" whiteboard tag.