Bug 457025 - [BiDi] Extend applyBidiProcessing API to support visual input field
Summary: [BiDi] Extend applyBidiProcessing API to support visual input field
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.5 M5   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-08 08:45 EST by Adir Pekarevich CLA
Modified: 2015-01-19 15:49 EST (History)
4 users (show)

See Also:

Attachments
Visual input field support (10.31 KB, patch)
2015-01-08 09:27 EST, Moshe WAJNBERG CLA 		no flags Details | Diff
Visual input field support (10.30 KB, patch)
2015-01-08 10:43 EST, Moshe WAJNBERG CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adir Pekarevich CLA 2015-01-08 08:45:11 EST 
We will extend API provided in https://bugs.eclipse.org/bugs/show_bug.cgi?id=403052
Comment 1 Moshe WAJNBERG CLA 2015-01-08 09:24:05 EST 
We want to extend the API applyBidiProcessing to support Visual input field.

Visual input field is described in the following article:
https://w3-connections.ibm.com/wikis/home?lang=en-us#!/wiki/GIG/page/GIG%23%23%23%20How%20to%20properly%20work%20with%20bidi%20data%20in%20visual%20layout%20in%20a%20web%20application

Basically we introduce 2 new constants : VISUAL_LEFT_TO_RIGHT and VISUAL_RIGHT_TO_LEFT for LTR/RTL visual fields.

The implementation is very similar to what has been done for base text direction:

We only have to add LRO/RLO at the beginning of the string and PDF to the end.
Comment 2 Moshe WAJNBERG CLA 2015-01-08 09:27:02 EST 
Created attachment 249784 [details]
Visual input field support

Hello Markus,

Can you please review this patch ?

Thank you
Comment 3 Moshe WAJNBERG CLA 2015-01-08 10:43:07 EST 
Created attachment 249791 [details]
Visual input field support
Comment 4 Markus Keller CLA 2015-01-19 15:49:06 EST 
Thanks for the patch. The IBM-internal link from comment 1 is not helpful for the Eclipse community, but http://www.w3.org/International/questions/qa-visual-vs-logical describes about the same.

Added that link to the Javadocs, fixed @since tags, and released with some more cleanup: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=22371404d2c6fbca6d1bf2a973a3f88cc6a8f101