Community
Participate
Working Groups
In a pure e4 application the e3 AboutDialog is not available/useable. A default AboutDialog would be very useful for us.
Fabian, I know you are working on a patch for the existing about dialog. Looking forward to your Gerrit upload..
https://git.eclipse.org/r/39173 We have converted the e3 dialog to e4. The help function is still missing. I found Bug 445600 - [Help] Add setHelp method to EHelpService. if the EHelpService work as required :-), i would use it in the AboutDialog plugin
(In reply to Fabian Miehe from comment #2) > The help function is still missing. > I found Bug 445600 - [Help] Add setHelp method to EHelpService. > > if the EHelpService work as required :-), i would use it in the AboutDialog > plugin I try to implement it latest next week now that I have a potential consumer. :-)
Hmmm my eclipse/gerrit config seems to be wrong. I updated the formater settings and now i have a new gerrit code review https://git.eclipse.org/r/#/c/39179/ Is it possible to merge https://git.eclipse.org/r/#/c/39179/ and https://git.eclipse.org/r/#/c/39173/ ?
(In reply to Fabian Miehe from comment #4) > Is it possible to merge https://git.eclipse.org/r/#/c/39179/ and > https://git.eclipse.org/r/#/c/39173/ ? You can use interactive rebase to combine both and abondan the second one.
No feedback from Fabian, getting late for 4.5 moving to 4.6.
WARNING: this patchset contains 10423 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
WARNING: this patchset contains 10424 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Guys, what's the status? Is there any chance you'll make it for 4.6?
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
Alexander indicated that he is interested in working on this one.
Alexander, any update on this one? Is this still planned for M3? I'm asking because I see UI freezes in the old FilteredTree (see Bug 550009) and can easily fix it for the new FilteredTree (see Bug 550023).
(In reply to Lars Vogel from comment #13) > Alexander, any update on this one? Is this still planned for M3? I'm asking > because I see UI freezes in the old FilteredTree (see Bug 550009) and can > easily fix it for the new FilteredTree (see Bug 550023). @Lars, I don't think it is realistic to fit in 4.13 as we need to redesign the implementation to fit e4. It is done for System Info collectors, but contributable About dialog pages are still under development. I have an idea to extend E4 Workbench model to cover the custom About dialog page functionality. Not sure if it is still considered as recommended way to go.
Based on Fabian Miehe's proposal I've just created my own plugin for the About dialog. It's a pure E4 plugin without dependencies to org.eclipse.ui. But before I'm contributing it to the Eclipse project I want to discuss some points, although I'm unsure if this is the right place for it (or if it is better to discuss via mailing list). Now some facts about the About Dialog :-) - does not depend on org.eclipse.ui (if someone wants to use the compat layer one can use the old AboutDialog class) - the dialog behaves mostly like the old one and shows about information from product file (of course!), installation details about features and plugins and has a system information view - it can show the log file from instance area - internally it uses the injection framework of Eclipse (only for a few classes) - currently it uses some deprecated classes from org.eclipse.update package (didn't found a viable alternative for this) - the messages are handled with NLS (but I wonder if we could use the TranslationService) - where possible the old classes were used A first impression can be seen in https://bitbucket.org/fakturamadev/fakturama-2/src/develop/Fakturama-Parent/org.fakturama.e4.ui.dialogs.ext. If it's ok I'll create a Gerrit commit for further discussion and reviewing. If there are other hints please provide me with some information.
(In reply to Ralf Heydenreich from comment #15) > > A first impression can be seen in > https://bitbucket.org/fakturamadev/fakturama-2/src/develop/Fakturama-Parent/ > org.fakturama.e4.ui.dialogs.ext. > > If it's ok I'll create a Gerrit commit for further discussion and reviewing. > If there are other hints please provide me with some information. Hi Ralph! Thank you for your effort! As I can see the trick was to copy all the needed E3 classes inside the new e4 bundle. Well, it is possible in theory as a temporary solution, but we will need to have corresponding tasks to rework this. I recommend you to put all these types to some ".internal.e3." subpackage tree to highlight this technical debt and also to remove all the E3 code you do not need for E4. In general, the contribution is huge and will require CQ procedure to follow, see https://wiki.eclipse.org/Development_Resources/Contribution_Questionnaire If you can split the contribution by self-sufficient parts that doesn't exceed 1k lines - it will be much eaisier to discuss and contribute it one by one. Thanks again and please keep us posted, AF
(In reply to Alexander Fedorov from comment #16) My apologies for the typo in your name, Ralf!
no problem :-) I'll create some follow-up tickets for the new implementation.
I think this would be really useful. I'm just wondering if it won't be possible to extract some of the classes into a public package that can be share between e4+e3?
Hi, I've created some follow-up tickets and implemented some functionalities. There are only two or three issues left which I want to implement asap. But for the moment I'm stuck with my own project. I think I can go further in a few days.
That sounds good, do you mind reference the corresponding ticket here?
* Bug #559693 * Bug #559694 * Bug #559695 * Bug #559696 * Bug #559697 * Bug #559698
Thanks Ralf let me know if you need any help in accomplish this.
