Bug 456530 - Rename in "Element ID" in Model Fragment Editor
Summary: Rename in "Element ID" in Model Fragment Editor
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Veselin Markov CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2015-01-02 11:48 EST by Veselin Markov CLA
Modified: 2015-04-28 15:04 EDT (History)
3 users (show)

See Also:

Attachments
Screenshot that shows the mentioned lable (25.22 KB, image/jpeg)
2015-01-04 04:21 EST, Veselin Markov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Veselin Markov CLA 2015-01-02 11:48:12 EST 
The label "Element ID" can easily be mistaken for the ID of the model fragment. To prevent that I propose to rename it to "Extended Element's ID".

To be changed in:
/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.properties : StringModelFragment_ParentId=Element ID
Comment 1 Wim Jongman CLA 2015-01-03 11:53:59 EST 
Can you supply a screenshot again?
Comment 2 Veselin Markov CLA 2015-01-04 04:21:53 EST 
Created attachment 249714 [details]
Screenshot that shows the mentioned lable

Sure.

There are two other things about this part of the editor - the find icon on the buttons is missing and container is not scrollable so that the buttons above the table are not visible when there isn't enough area to fit all of them. 
Maybe I should open anouther bug about this. What do you think?
Comment 3 Lars Vogel CLA 2015-03-15 11:08:06 EDT 
I find it hard to understand "Extended Element's ID". What do you think about "Target element ID"?
Comment 4 Veselin Markov CLA 2015-03-26 16:54:53 EDT 
I thought it's important to describe the purpose of a fragment. As I see it, it extends the functionality of an element in the application model. That's why I think it's more intuitive for beginners.

If you still think Target element ID is the better choice then I'll implement your suggestion.
Comment 5 Lars Vogel CLA 2015-03-26 23:35:01 EDT 
(In reply to Veselin Markov from comment #4)
> I thought it's important to describe the purpose of a fragment. As I see it,
> it extends the functionality of an element in the application model. That's
> why I think it's more intuitive for beginners.
> 
> If you still think Target element ID is the better choice then I'll
> implement your suggestion.

Extended Element's ID is also fine if you prefer this.
Comment 6 Eclipse Genie CLA 2015-03-27 14:01:35 EDT 
New Gerrit change created: https://git.eclipse.org/r/44778
Comment 8 Lars Vogel CLA 2015-04-21 04:28:58 EDT 
Thanks Veselin for the correction.
Comment 9 Lars Vogel CLA 2015-04-21 04:29:37 EDT 
.
Comment 10 Lars Vogel CLA 2015-04-28 15:04:11 EDT 
Verified in Build id: N20150425-1500