Bug 456291 - [Preferences] Two empty "colors and fonts" preference groups
Summary: [Preferences] Two empty "colors and fonts" preference groups
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Robert Roth CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2014-12-29 17:33 EST by Andrey Loskutov CLA
Modified: 2015-04-29 10:49 EDT (History)
2 users (show)

See Also:

Attachments
empty groups (81.48 KB, image/png)
2014-12-29 17:33 EST, Andrey Loskutov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2014-12-29 17:33:56 EST 
Created attachment 249652 [details]
empty groups

Eclipse 4.5 M4 Build id: I20141210-2000.

Window->Preferences->General->Appearance->Colors and fonts contain two empty groups:
1) The first in the list has no name and no content
2) "Other defined by CSS" group is empty

See attached screenshot.

Two issues:
1) The empty groups shouldn't be empty or they shouldn't be shown.
2) There shouldn't exist groups without name.
Comment 1 Markus Keller CLA 2015-03-03 11:14:39 EST 
The first (empty) group has been deleted with bug 461289.

The second "Other defined by CSS" group has been added with bug 419018, and I see code references to the "org.eclipse.ui.themes.CssTheme" category in org.eclipse.ui.internal.themes.ThemesExtension.DEFAULT_CATEGORY_ID. I don't know if that's actually used, but I wouldn't remove the category without checking those references first.

If the category is only used depending on some user or product configuration, then a solution could be to hide empty categories in the ColorsAndFontsPreferencePage.
Comment 2 Eclipse Genie CLA 2015-04-29 06:31:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/46760
Comment 3 Dani Megert CLA 2015-04-29 10:49:24 EDT 
Thanks Robert!