Community
Participate
Working Groups
IMHO deprecation requires a practical replacement. org.eclipse.ui.editorActions is still in use by JDT so that provides no exemplary way forward. For my own code I'm trying to move on but have given up and raise this Bug instead. a) the schema description has an old example. This should be augmented by the an example rewrite using org.eclipse.ui.commands. b) org.eclipse.debug.ui.actions.RulerToggleBreakpointActionDelegate should have comments that explain how to use it in a post-deprecation world.
Ping. org.eclipse.ui.editorActions is still in use by org.eclipse.ui.editors, notably to use actionID="RulerDoubleClick" for which no alternative seems to be available. I note that in M6, the menu rendering of accelerators in the ruler menu may show "Ctrl+Double Click" suggesting that the "Double Click" event is being reified as a key, but attempting to use "Double Click" or "DOUBLE_CLICK" in a key sequence gives a parsing error. Certainly no sign of "DOUBLE_CLICK" in the source. How is a RulerDoubleClick bound to a Command/Handler without using deprecated plugin.xml declarations?
MAJOR a) because good Eclipse citizens who try to eliminate deprecations waste time failing to do so b) because use of deprecated UI by the platform undermines the credibility of the platform. Either provide the replacements or suspend the deprecation.
(In reply to Ed Willink from comment #2) > Either provide the replacements or suspend the deprecation. The deprecation help new implementations to avoid using these outdated constructs. Updating existing code in the Eclipse project is desired but not always possible due to resource constraints. Contributions are welcome.
The problem I (and I assume Ed as well) have is to find suitable replacements
(In reply to Christian Dietrich from comment #4) > The problem I (and I assume Ed as well) have is to find suitable replacements I suggest to open a new bug for a usage for RulerDoubleClick and ask to replace it with a new construct.
This is the bug. Deprecations were applied without replacements. We still need guidance on the replacments of which RulerDoubleClick is just one. Proper deprecations e.g. org.eclipse.ui.commands. Priority have * @deprecated This concept is now captured in the <code>ISources</code> integer * constants. When I gave up waiting for guidance, I found that recoding RulerToggleBreakpointActionDelegate was rather easy and resulted in simpler code. But why isn't this shared centrally? When I tried to recode RulerDoubleClick, I failed, probably because the number of internal classes that I needed to rip-off to workaround private/package access limitations became untenable.
(In reply to Ed Willink from comment #6) > This is the bug. No this bug is too general and it says: "org.eclipse.ui.editorActions" should not be deprecated without a replacement". That is a WONTFIX. Please open a new bug for an individual usage of "org.eclipse.ui.editorActions" in platform code.
