Bug 455568 - [Min/Max] [Model] Add Special tag to allow Area Children to be maximizable
Summary: [Min/Max] [Model] Add Special tag to allow Area Children to be maximizable
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows NT
: P3 enhancement (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Jonas Helming CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 498561 (view as bug list)
Depends on:
Blocks: 477674
  Show dependency tree
 
Reported: 2014-12-18 03:28 EST by Eugen Neufeld CLA
Modified: 2016-07-27 07:26 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugen Neufeld CLA 2014-12-18 03:28:16 EST 
We suggest to add a special tag, which will render the area with individually maximizable children. 
This way it is possible to maximize the whole area containing the children or to maximize an individual child of the area. Thus it would be a mixture of an Area and a PartSashContainer.

We weren't able to do implement this as a specific element with a dedicated renderer as the main work happens in the MinMaxAddon which must be aware of this tag.

If there is interest in such an enhancement, I would push my code to gerrit.
Comment 1 Lars Vogel CLA 2014-12-18 03:44:54 EST 
(In reply to Eugen Neufeld from comment #0)
> If there is interest in such an enhancement, I would push my code to gerrit.

Sounds interesting but we need to see this code in action to judge that. Please upload your code.
Comment 2 Eugen Neufeld CLA 2015-01-07 09:38:15 EST 
Hi, 
I pushed my change based on the latest master to https://git.eclipse.org/r/#/c/39128/

Cheers,
Eugen
Comment 3 Jonas Helming CLA 2015-02-05 10:27:52 EST 
We have found a regression. We will update the patch next week, once we have fixed it.
Comment 4 Eugen Neufeld CLA 2015-03-27 07:49:58 EDT 
I updated and rebased the contribution. 
Cheers,
Eugen
Comment 5 Lars Vogel CLA 2015-03-27 08:21:24 EDT 
Thanks Eugen, the M7 target makes this visible in our workqueue. We try to have a look for M7.
Comment 6 Lars Vogel CLA 2015-04-07 07:37:21 EDT 
See comments in Gerrit review.
Comment 8 Andrey Loskutov CLA 2016-07-13 10:44:45 EDT 
This causes API error:
Description	Resource	Path	Location	Type
The minor version should be incremented in version 1.4.100, since new APIs have been added since version 1.4.0	MANIFEST.MF	/org.eclipse.e4.ui.workbench/META-INF	line 4	Version Numbering Problem
Comment 9 Eclipse Genie CLA 2016-07-13 11:13:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/77254
Comment 11 Andrey Loskutov CLA 2016-07-14 04:19:23 EDT 
(In reply to Eclipse Genie from comment #10)
> Gerrit change https://git.eclipse.org/r/77254 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=a3aebbc88122d60b06788784447e71f064ab514d

Thanks, looks good now
Comment 12 Eugen Neufeld CLA 2016-07-27 04:05:45 EDT 
The fix added a NPE when double clicking a tab.
Comment 13 Eclipse Genie CLA 2016-07-27 04:08:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/77948
Comment 15 Andrey Loskutov CLA 2016-07-27 07:26:35 EDT 
*** Bug 498561 has been marked as a duplicate of this bug. ***