Bug 454866 - generate download "%index%" markers as simple "include" files
Summary: generate download "%index%" markers as simple "include" files
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 469107 415793
  Show dependency tree
 
Reported: 2014-12-11 07:03 EST by David Williams CLA
Modified: 2015-06-02 06:54 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-12-11 07:03:34 EST
or, possibly create them as simple XML files? 

The files I'm talking about are the ones for "artifacts to download". 

We currently "mark" the location in the template with symbols such as %sdk%, which our custom "generate indexes" code "substitutes" (replaces) with a simply set of html markup, AND even a PHP method call to complete the row server side. 

The beginning of the %sd% block (which is similar to others) looks like 

<tr>
<td>Windows</td>
<?php genLinks("eclipse-SDK-${BUILD_ID}-win32.zip"); ?>
</tr>
<tr>
<td>Windows (x86_64)</td>
<?php genLinks("eclipse-SDK-${BUILD_ID}-win32-x86_64.zip"); ?>
</tr>
<tr>
<td>Linux (x86/GTK+)</td>
<?php genLinks("eclipse-SDK-${BUILD_ID}-linux-gtk.tar.gz"); ?>
</tr>
<tr>
<td>Linux (x86_64/GTK+)</td>
<?php genLinks("eclipse-SDK-${BUILD_ID}-linux-gtk-x86_64.tar.gz"); ?>
</tr>

As can be seen, it does not contribute much, for these "downloads" sections (it does more for test results summary and compile logs summary). The "genLinks functions is one of our custom php unction which (currently) generates 3 columns for the DL table. 

Whats generated here, is partially determined by the "testManifest.xml" file. 

So, my idea is, for this download section, either "do the work" directly with PHP, or, if done with "indexer", it should provide each of the %sdk% like sections as separate files, , say "sdkDL.php" and then the "template" file, could simply "include" those separate files where it wanted them.  

The provides a looser coupling, than the indexer changing "index.php.template" file directly, since then, once done, it's done. If left as separate files. It'd be easier to change the "template file" (even "dynamically") to display as desired. For example, just and example, it it would be easier to have even "separate pages", ... some displaying some items, some displaying others, without ever changing the 'indexer'. 

Part of the idea of this change its to avoid processing the "index.php" multiple times, as we now do.