Bug 454281 - collectDataSetDesign() not reflecting changes made to the DataSetDesign when clicking OK
Summary: collectDataSetDesign() not reflecting changes made to the DataSetDesign when ...
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 4.4.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Birt-ReportDesigner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-05 13:15 EST by Rémi Dettai CLA
Modified: 2014-12-05 13:15 EST (History)
0 users

See Also:


Attachments
This shows the incoherent state generated by the bug (197.99 KB, image/png)
2014-12-05 13:15 EST, Rémi Dettai CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rémi Dettai CLA 2014-12-05 13:15:49 EST
Created attachment 249205 [details]
This shows the incoherent state generated by the bug

I am developing an ODA Designer plugin for BIRT. I noticed that when you are implementing the DataSetWizardPage.collectDataSetDesign() method which is in charge of saving you designer's state, changes made to the DataSetDesign object are not properly handled. In particular, if you are saving the structure of your data through the result sets attribute(for instance with the DataSetDesign.setPrimaryResultSet() method) it does reflect changes made to the query if the window is exited by clicking OK.

This can be reproduced with the Excel Datasource:
- create an excel data source and data set with at least one column of data.
- validate, then go back to the data set editor
- in the Select Column tab change the type of one of your columns and click directly on OK
- open the data set again and go to the Output Column tab, the change has not been propagated (the type for that column will be the same as before).

This is problematic because you will have a different type in the run-time environment and in the design environment, so your report will probably crash at runtime.