Community
Participate
Working Groups
I'm having a hard time telling if buttons are enabled or not since Luna: http://i.imgur.com/5AwlmfG.png It was much more obvious on previous release: http://i.imgur.com/R3tUPxR.png
Can you show the same thing for comparison. In first screenshot the red button is enabled and the next 3 buttons not. In your second the red button is not enable.d
Here's the same for both: http://i.imgur.com/6447Yt0.png http://i.imgur.com/7vtyc8J.png It's the "clear console" button which is harder to differentiate
Tony, anything you can do here to improve the disabled icons mentioned here?
Created attachment 249002 [details] animation example Looks fine here on the latest Luna SR. Is this a bug specific to the current mars developer builds? If so, I will check that out. I'm attaching an animation with a 2 second delay that toggles between them. It's pretty obvious when the icon is enabled or disabled.
Of course it's easier to tell when you have both images side by side but that's not the case usually: http://i.imgur.com/IFv9rRX.png The cross should be darker when enabled IMO. (just like previous releases: http://i.imgur.com/6447Yt0.png)
I've increased the amount of contrast on these icons (darker borders) which should alleviate the issue. The disabled icons are are created by running a "deconstrast" filter over the enabled versions.
Created attachment 250549 [details] increased contrast Attached is a gallery with increased contrast on the edges for the remove icons. These will be going into a submission soon and should make things more obvious.
(In reply to Jean-Pierre froud from comment #5) > Of course it's easier to tell when you have both images side by side but > that's not the case usually: http://i.imgur.com/IFv9rRX.png > > The cross should be darker when enabled IMO. (just like previous releases: > http://i.imgur.com/6447Yt0.png) Jean-Pierre, can you tell me which toolbar you are looking at? Tony provided new icons but I'm not sure that toolbar is displayed in your screenshot to test the change.
(In reply to Lars Vogel from comment #8) > Jean-Pierre, can you tell me which toolbar you are looking at? Tony provided > new icons but I'm not sure that toolbar is displayed in your screenshot to > test the change. I assume this is about the debug icons. Gerrit change coming soon.
New Gerrit change created: https://git.eclipse.org/r/44550
(In reply to Lars Vogel from comment #8) > Jean-Pierre, can you tell me which toolbar you are looking at? Tony provided > new icons but I'm not sure that toolbar is displayed in your screenshot to > test the change. Icons on the "console" view
(In reply to Jean-Pierre froud from comment #11) > (In reply to Lars Vogel from comment #8) > > Jean-Pierre, can you tell me which toolbar you are looking at? Tony provided > > new icons but I'm not sure that toolbar is displayed in your screenshot to > > test the change. > > Icons on the "console" view Above review should fix that. Sarika please review.
Thanks Lars, should we not change all the lock_co.png which are there in org.eclipse.debug.ui and org.eclipse.ui.console plugins ?
(In reply to Sarika Sinha from comment #13) > Thanks Lars, should we not change all the lock_co.png which are there in > org.eclipse.debug.ui and org.eclipse.ui.console plugins ? AFAICS org.eclipse.ui.console does not have a lock_co.png and the dlcl16 version of lock_co.png in org.eclipse.debug.ui was not modified by Tony.
I see 3 lock_co.png files in ui.console /org.eclipse.ui.console/icons/full/clcl16/lock_co.png /org.eclipse.ui.console/icons/full/dlcl16/lock_co.png /org.eclipse.ui.console/icons/full/elcl16/lock_co.png
(In reply to Sarika Sinha from comment #15) > I see 3 lock_co.png files in ui.console > > /org.eclipse.ui.console/icons/full/clcl16/lock_co.png > /org.eclipse.ui.console/icons/full/dlcl16/lock_co.png > /org.eclipse.ui.console/icons/full/elcl16/lock_co.png Strange, in my Gerrit branch I did not see them, only in master. Sorry for this, I updated the Gerrit review with icons for console also. https://git.eclipse.org/r/44550
Gerrit change https://git.eclipse.org/r/44550 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=619557613721aeceb157960116b5fdb95548c282
Thanks Tony and Lars!!
