Community
Participate
Working Groups
maven desriptors META-INF/maven/... tend to add lengthy paths inside the jar archive being created. For features, which are always unpacked in the installation, this can cause path length problems on Windows (hey Windows, it's 2014...) Maven descriptors are not really needed so if they cause potential problems we should not generate them at least for features by default.
I suppose that the <archive> configuration parameter [1] is shared by several packaging-plugin goals, so I don't know if it makes sense to only change the default for features. BTW, some site doc for the parameter would be nice :-) [1] https://www.eclipse.org/tycho/sitedocs/tycho-packaging-plugin/package-plugin-mojo.html#archive
For the apparently correct configuration syntax, see bug 401040 comment 8.
Pushed a patch for review: https://git.eclipse.org/r/#/c/36777/ Actually the <archive> parameter is not shared between the different packaging plugin goals, so it was easy to had 2 different defaults (leave plugin packaging as it was and setting the default for features to not include the maven stuff). If you think that the default should be the same for both, I can change that in the plugin mojo as well.
I'm for having false everywhere because even bundles can be exploded on install
(In reply to Thomas Schindl from comment #4) > I'm for having false everywhere because even bundles can be exploded on > install OK with me. @Igor do you know anything/anyone we would break by not adding META-INF/maven descriptors by default to feature and plugin jars anymore?
https://github.com/ifedorenko/com.ifedorenko.m2e.sourcelookup will break without maven metadata.
(In reply to Igor Fedorenko from comment #6) > https://github.com/ifedorenko/com.ifedorenko.m2e.sourcelookup will break > without maven metadata. In this case, I'd say that we should only change the default for features.
Submitted Martin's patch: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=2e6145f496ee9805e8292e5195709ec42683d32b @Martin: Thank you very much for contributing this patch with excellent site doc and test coverage.
(In reply to Igor Fedorenko from comment #6) > https://github.com/ifedorenko/com.ifedorenko.m2e.sourcelookup will break > without maven metadata. FWIW and in case this issue is ever re-opened: Eclipse Code Recommenders also tries to identify dependencies based on their metadata like META-INF/maven/... Thus, having this information available for bundles is beneficial to us as well.
