Community
Participate
Working Groups
https://git.eclipse.org/r/#/c/34585/ is another example in which we make it harder for our contributor to contribute because of the existing whitespace issues. I suggest we activate the save actions on the plug-ins and fix existing issues.
Code cleanup for org.eclipse.ui.tests.rcp: https://git.eclipse.org/r/35840 Activate the save actiosn for it:
Acivate the save actions for org.eclipse.ui.tests.rcp: https://git.eclipse.org/r/35841
(In reply to Lars Vogel from comment #1) > Code cleanup for org.eclipse.ui.tests.rcp: https://git.eclipse.org/r/35840 > Activate the save actiosn for it: Merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9d46fd25916443921db384831f085f1d7c892005
(In reply to Lars Vogel from comment #2) > Acivate the save actions for org.eclipse.ui.tests.rcp: > https://git.eclipse.org/r/35841 Merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e96cc52795c7b2ad66ae15455bfe2ca398ea222c
Remove whitespace in org.eclipse.ui.tests: https://git.eclipse.org/r/#/c/35843/ Activate the save actions for org.eclipse.ui.tests: https://git.eclipse.org/r/35844
(In reply to Lars Vogel from comment #5) > Remove whitespace in org.eclipse.ui.tests: > https://git.eclipse.org/r/#/c/35843/ > Activate the save actions for org.eclipse.ui.tests: > https://git.eclipse.org/r/35844 Merged with git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c7a74830a5ca9d4f853e16b703eb3b34580cc816 and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=813ea0c5da684b7a8be2c0a84f61276b18bb1950
I just had to use Show Annotations on /org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/datatransfer/ExportArchiveFileOperationTest.java Commit c7a74830a5ca9d4f853e16b703eb3b34580cc816 uses this bug's title "Bug 449736 - [Tests] Solve whitespace issues in org.eclipse.ui.tests plug-ins", but it - doesn't solve whitespace issues (crappy indents with spaces are still there) - performs other code changes to use enhanced for-loops, blocks in if-statements, etc. For me, such commits only make the situation worse: - From now on, Show Annotations always causes more work. - The commit message says looks like it's only about whitespace changes, so I assume this commit cannot introduce any functional changes. While we try hard to make clean-ups semantically-preserving, we're not able to guarantee that. So the commit message effectively lies. - If you do such large-scale commits, then at least make sure they're actually doing the job, so that they don't have to be followed-up with even more commits that make the history hard to read.
(In reply to Markus Keller from comment #7) Just to be clear: You can't fix these issues any more, but please avoid them in the future.
(In reply to Markus Keller from comment #7) > For me, such commits only make the situation worse: - doesn't solve whitespace issues (crappy indents with spaces are still there) I used the JDT clean up actions to remove tailing whitespace. Is their anther JDT option to cleanup the remaining whitespace issues. In Gerrit I have only seen trailing whitespace issues with contributions. - performs other code changes to use enhanced for-loops, blocks in if-statements, etc. That should not have been the case, sorry for this. I typically try to do really focused changes and mixing whitespace changes and other cleanup work is something I strongly try to avoid. Sorry https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c7a74830a5ca9d4f853e16b703eb3b34580cc816 was clearly wrongly done. > - From now on, Show Annotations always causes more work. Are you aware that the whitespace changes can be ignored in EGit for the blame annotations? To enable this select Preferences > Team > Git, Ignore whitespace changes.
org.eclipse.e4.emf.xpath.test https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6ab06a10379b4379c4f2776f29b90176d59330f5
org.eclipse.e4.ui.menu.tests http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=829741f17820938870f2cd4b60340e5a0f695b85
Removed whitespace from org.eclipse.jface.tests.databinding with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ae182780e6f26414e097f5945baebe7fc3824f64
org.eclipse.ui.tests.navigator https://git.eclipse.org/r/39888
(In reply to Lars Vogel from comment #13) > org.eclipse.ui.tests.navigator https://git.eclipse.org/r/39888 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b84fbd59302fdc921a05a49ae3e2c4ac0ebd3815
New Gerrit change created: https://git.eclipse.org/r/43397
Gerrit change https://git.eclipse.org/r/43397 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b35d5f83e44cf0c48f230217aba59b4fd219a212
New Gerrit change created: https://git.eclipse.org/r/43507
New Gerrit change created: https://git.eclipse.org/r/43508
New Gerrit change created: https://git.eclipse.org/r/43509
New Gerrit change created: https://git.eclipse.org/r/43510
New Gerrit change created: https://git.eclipse.org/r/43512
New Gerrit change created: https://git.eclipse.org/r/43513
New Gerrit change created: https://git.eclipse.org/r/43514
New Gerrit change created: https://git.eclipse.org/r/43515
New Gerrit change created: https://git.eclipse.org/r/43516
New Gerrit change created: https://git.eclipse.org/r/43517
New Gerrit change created: https://git.eclipse.org/r/43518
Gerrit change https://git.eclipse.org/r/43507 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=92dfc26d552c54e9f2fb32b2b79721ac7cfa25a1
Gerrit change https://git.eclipse.org/r/43508 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6b7496223a0f5d16e5e22d3e223584ba8289cbd5
Gerrit change https://git.eclipse.org/r/43509 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2dc02579e98767634204f6000df7a48e3e98c574
Gerrit change https://git.eclipse.org/r/43510 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6044ae4f8078b017d1b2b0621d8f816a26cd0166
Gerrit change https://git.eclipse.org/r/43512 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=08131dfad251299fa4182deee016f450b5316315
Gerrit change https://git.eclipse.org/r/43513 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d20e0fe0210bd47d843be1ed0489609d09d2330b
Gerrit change https://git.eclipse.org/r/43514 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=80649a009dfb21accee082ecbdcd117460b6720d
Gerrit change https://git.eclipse.org/r/43515 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9ab5e5216430b8847f9c25e11c31afbc3521d5d0
Gerrit change https://git.eclipse.org/r/43516 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a85f5faa2038ea8ffcf2b849c211f3830ec55ca4
Gerrit change https://git.eclipse.org/r/43517 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0237d50794697de4535ed16e566e0270942cab6e
Gerrit change https://git.eclipse.org/r/43518 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2b460e507e33085537b72a69b9c27c6203ff3523
.
Verified in Git. Lots of whitespace cleanup actions, if we missed something we use new bug reports.
