Bug 446418 - Update org.eclipse.pde.ui.templates to Java 1.6
Summary: Update org.eclipse.pde.ui.templates to Java 1.6
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M4   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 441331
  Show dependency tree
 
Reported: 2014-10-09 04:41 EDT by Lars Vogel CLA
Modified: 2014-12-09 07:05 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-10-09 04:41:59 EDT 
I suggest to update org.eclipse.pde.ui.templates to Java 1.6 as most of the PDE plug-ins are already upgraded. This would also involve fixing all the generics warnings.
Comment 1 Lars Vogel CLA 2014-10-09 04:47:18 EDT 
Update of the BREE

https://git.eclipse.org/r/34623

Adding the @Override and @Deprecated annotations

https://git.eclipse.org/r/34624

Removing the generics warnings

https://git.eclipse.org/r/34625

Removing the unnecessary Non-Javadoc statements

https://git.eclipse.org/r/34626
Comment 2 Lars Vogel CLA 2014-11-05 01:57:25 EST 
Vikas, any update on the review?
Comment 3 Vikas Chandra CLA 2014-11-05 02:00:56 EST 
I don't think it is urgent. This will be done by 4.5 M4 timeframe.
Comment 4 Lars Vogel CLA 2014-11-05 02:02:51 EST 
(In reply to Vikas Chandra from comment #3)
> I don't think it is urgent. This will be done by 4.5 M4 timeframe.

Once we have this, I plan to contribute an Eclipse 4 template into PDE via Bug 441331.
Comment 5 Vikas Chandra CLA 2014-11-05 02:04:41 EST 
Oh ok. Then I will review today or tomorrow.
Comment 6 Vikas Chandra CLA 2014-11-06 09:33:17 EST 
I plan to commit it tomorrow after a quick review.
Comment 7 Vikas Chandra CLA 2014-11-07 06:33:17 EST 
Thanks Lars. I did a quick review. All looked good

Commited to 4.5 (master) via

Update of the BREE
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e07ca90978c9b63bff02237111e190179716a242

Adding the @Override and @Deprecated annotations
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=7190e4a854d543f301f51e616476800f003c7cfe

Removing the generics warnings
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=0268d7fc6bf9f1d7223cf096aeab58f2251f4001

Removing the unnecessary Non-Javadoc statements
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=cf80156b6afe2ad8e9f51408bd16fb501e9037a8
Comment 8 Vikas Chandra CLA 2014-11-07 06:37:02 EST 
See commits in previous comment. Bug 441331 should be unblocked now.
Comment 9 Vikas Chandra CLA 2014-12-09 07:05:35 EST 
Verified based on latest master code ( 9 dec 2014)