Community
Participate
Working Groups
I plan to contribute our e4 tools wizard for creating Eclipse 4 RCP applications to PDE. This is a work item for me.
Is this on for 4.5 M4? If yes, we should plan early enough.
If this cant go in 4.5M4, probably we can move it to 4.5 M5
(In reply to Vikas Chandra from comment #2) > If this cant go in 4.5M4, probably we can move it to 4.5 M5 I could hold up by other work, sorry for this, I try to implement that for M5.
Lars, I am moving this to 4.5M6 as today is the last day to commit for 4.5M5
New Gerrit change created: https://git.eclipse.org/r/43621
New Gerrit change created: https://git.eclipse.org/r/43893
I created this review : https://git.eclipse.org/r/#/c/43893/ But the hudson build failed with this error : https://hudson.eclipse.org/platform/job/eclipse.pde.ui-Gerrit/267/console So, I tried to build it at home, using mvn -X clean install and I got this error : Something wrong with org.eclipse.pde.api.tools ? Any Idea ? Thanks [ERROR] Cannot resolve project dependencies: [ERROR] Software being installed: org.eclipse.pde.api.tools 1.0.700.qualifier [ERROR] Missing requirement: org.eclipse.pde.api.tools 1.0.700.qualifier requires 'bundle org.eclipse.osgi [3.4.0,4.0.0)' but it could not be found [ERROR] [ERROR] See http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help. [ERROR] Cannot resolve dependencies of MavenProject: org.eclipse.pde:org.eclipse.pde.api.tools:1.0.700-SNAPSHOT @ /Users/olivier/git/eclipse.pde.ui/apitools/org.eclipse.pde.api.tools/pom.xml: See log for details -> [Help 1] org.apache.maven.MavenExecutionException: Cannot resolve dependencies of MavenProject: org.eclipse.pde:org.eclipse.pde.api.tools:1.0.700-SNAPSHOT @ /Users/olivier/git/eclipse.pde.ui/apitools/org.eclipse.pde.api.tools/pom.xml at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead(TychoMavenLifecycleParticipant.java:92) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:317) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213) at org.apache.maven.cli.MavenCli.main(MavenCli.java:157) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:483) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) Caused by: org.eclipse.tycho.artifacts.DependencyResolutionException: Cannot resolve dependencies of MavenProject: org.eclipse.pde:org.eclipse.pde.api.tools:1.0.700-SNAPSHOT @ /Users/olivier/git/eclipse.pde.ui/apitools/org.eclipse.pde.api.tools/pom.xml at org.eclipse.tycho.p2.resolver.P2ResolverImpl.resolveDependencies(P2ResolverImpl.java:202) at org.eclipse.tycho.p2.resolver.P2ResolverImpl.resolveDependencies(P2ResolverImpl.java:116) at org.eclipse.tycho.p2.resolver.P2DependencyResolver.doResolveDependencies(P2DependencyResolver.java:367) at org.eclipse.tycho.p2.resolver.P2DependencyResolver.resolveDependencies(P2DependencyResolver.java:335) at org.eclipse.tycho.core.resolver.DefaultTychoResolver.resolveProject(DefaultTychoResolver.java:117) at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead(TychoMavenLifecycleParticipant.java:87) ... 13 more Caused by: org.eclipse.tycho.p2.util.resolution.ResolverException: See log for details at org.eclipse.tycho.p2.util.resolution.ProjectorResolutionStrategy.resolve(ProjectorResolutionStrategy.java:88) at org.eclipse.tycho.p2.util.resolution.AbstractResolutionStrategy.resolve(AbstractResolutionStrategy.java:42) at org.eclipse.tycho.p2.resolver.P2ResolverImpl.resolveDependencies(P2ResolverImpl.java:195) ... 18 more [ERROR] [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
https://hudson.eclipse.org/platform/job/eclipse.platform.runtime-Gerrit/
(In reply to Olivier Prouvost from comment #7) > I created this review : > > https://git.eclipse.org/r/#/c/43893/ > > But the hudson build failed with this error : > > https://hudson.eclipse.org/platform/job/eclipse.pde.ui-Gerrit/267/console Build failure should be fixed, if you push an update it should build again.
Yes It worked !
Vikas, can this be integrated into early M7? We have a fork of the PDE wizard in eclipse.platform.ui.tools and this would allow us to get rid of it.
Hi Lars, What will be the impact of this change on PDE ? Or will this change/refactoring just affect e4 applications ?
(In reply to Vikas Chandra from comment #12) > Hi Lars, > > What will be the impact of this change on PDE ? Or will this > change/refactoring just affect e4 applications ? Except this and potential more future templates I do not see a necessary change in PDE. We want to use the existing PDE template framework.
Gerrit change https://git.eclipse.org/r/43893 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e1fa96c02a82a5a5f2a9e96c62f2f2fb6a8b13d3
Thanks Olivier/Lars Looks fine. All the tests run fine. See previous comment for commit id.
This should be added to the N&N for M7. Thanks a bunch Olivier.
Tested in 4.5.0.I20150428-0100. Looks good. I will suggest minor changes in the labels via Bug 465680.
