Bug 445538 - [Perspectives] Pin Editor command broken and can no longer be added to perspective's toolbar
Summary: [Perspectives] Pin Editor command broken and can no longer be added to perspe...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.5 M6   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks: 420956
  Show dependency tree
 
Reported: 2014-09-30 12:20 EDT by Randy Hudson CLA
Modified: 2015-04-15 11:30 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2014-09-30 12:20:13 EDT 
In the customize perspective dialog, Under the "Navigate" section, there is a "Pin Editor" action.  It appears gray, and if you check it, an error dialog appears:

"Pin Editor" cannot be made visible because it is in the unavailable "null" command group.

Would you like to switch to the Command Group Availability tab?

Of course if you look at the command groups, there is no "null" group listed.  It is on longer possible to add this action to the toolbar (which is useful, since there's no other way to know if the current editor is pinned)

In older workspaces, where I added this action to the toolbar before this regression was introduced, the action still appears on the toolbar, but no longer works.
Comment 1 Dirk Olmes CLA 2014-10-31 12:02:07 EDT 
This seems to be an issue with the Eclipse for Java Developers version. I tried to reproduce/debug the issue with a Standard Eclipse for PDE developers and in that version the editor pinning is avaliable and works.
Comment 2 Andrey Loskutov CLA 2015-01-24 18:48:11 EST 
Still reproducible with latest patches to bug 420956, I'm on a "classic" Eclipse 4.5 HEAD.
Comment 3 Andrey Loskutov CLA 2015-01-26 10:39:32 EST 
(In reply to Andrey Loskutov from comment #2)
> Still reproducible with latest patches to bug 420956, I'm on a "classic"
> Eclipse 4.5 HEAD.

Not right. The problem here is the initial preference setting in the Eclipse distribution one uses, and most likely caused by WorkbenchActionBuilder way to contribute buttons, see bug 180308 comment 35.

With the N20150124-1500 the enablement/disablement of the button starts to work after enabling General->Editors->Close automatically *and restarting* Eclipse.
Comment 4 Andrey Loskutov CLA 2015-01-26 18:44:30 EST 
(In reply to Andrey Loskutov from comment #3)
> The problem here is the initial preference setting in the Eclipse
> distribution one uses, and most likely caused by WorkbenchActionBuilder way
> to contribute buttons, see bug 180308 comment 35.

Yep. I have a fix but I need to polish it.
Comment 5 Andrey Loskutov CLA 2015-01-27 08:54:55 EST 
Fix: https://git.eclipse.org/r/40449.
Comment 7 Dani Megert CLA 2015-03-06 05:48:48 EST 
There are some remaining problems discussed in the Gerrit change. Please file new bugs for those before closing this one.
Comment 8 Andrey Loskutov CLA 2015-03-06 07:30:23 EST 
(In reply to Dani Megert from comment #7)
> There are some remaining problems discussed in the Gerrit change. Please
> file new bugs for those before closing this one.

I created bug 461579 for the only left problem I'm aware of. Can we fix this bug now or are there more issues left which I've overlooked?
Comment 9 Noopur Gupta CLA 2015-03-08 15:16:06 EDT 
Reported bug 461667 also. Closing this bug as fixed.
Comment 10 Noopur Gupta CLA 2015-03-08 15:16:25 EDT 
Reported bug 461667 also. Closing this bug as fixed.
Comment 11 Eclipse Genie CLA 2015-03-19 16:00:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/44208
Comment 12 Andrey Loskutov CLA 2015-03-19 16:01:26 EDT 
Verified with Build id: I20150318-2000
N&N notes: https://git.eclipse.org/r/44208
Comment 14 Eclipse Genie CLA 2015-04-15 06:54:07 EDT 
New Gerrit change created: https://git.eclipse.org/r/45857