Bug 44459 - First Link (Help > Welcome...) on Welcome Page doesn't work
Summary: First Link (Help > Welcome...) on Welcome Page doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.0 M5   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-08 11:42 EDT by Markus Keller CLA
Modified: 2003-11-21 10:14 EST (History)
4 users (show)

See Also:


Attachments
Patch for org.eclipse.ui.workbench (1.91 KB, patch)
2003-10-10 11:09 EDT, Kim Horne CLA
no flags Details | Diff
Patch for org.eclipse.platform (909 bytes, patch)
2003-10-10 11:09 EDT, Kim Horne CLA
no flags Details | Diff
Revised patch for org.eclipse.platform (post-RCP) (853 bytes, text/plain)
2003-11-11 01:05 EST, Nick Edgar CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2003-10-08 11:42:44 EDT
I20031008

- start eclipse with new workspace
- in the Eclipse Platform Welcome page, click on the first link "Help > Welcome..."

!ENTRY org.eclipse.ui 4 4 Oct 08, 2003 17:34:25.512
!MESSAGE Unable to load class org.eclipse.ui
org.eclipse.ui.internal.QuickStartAction
Unable to load class org.eclipse.ui org.eclipse.ui.internal.QuickStartAction
Comment 1 Tod Creasey CLA 2003-10-08 12:43:20 EDT
You appear to have some classpath problems in general here - this is 
also causing your issues in Bug 44468. Is anything working for you?

I am marking as WORKSFORME as I can't replicate this problem in the 20031008 
integration build
Comment 2 Markus Keller CLA 2003-10-08 13:04:07 EDT
markus_keller != martin_aeschlimann

I can reproduce this behavior:
- extract I20031008
- doubleclick eclipse.exe
- click on the link
-> find the message in the log

The rest of eclipse works as usual - I experience no classpath problems.
As for bug 44468: I can reproduce that in I20031007, but it's OK on I20031008
Comment 3 Tod Creasey CLA 2003-10-08 13:53:56 EDT
Is this the entire log Markus?
Comment 4 Kim Horne CLA 2003-10-08 14:03:34 EDT
This also works fine for me (with and without Role support enabled).
Comment 5 Dani Megert CLA 2003-10-09 04:00:43 EDT
Same for me using fresh I20031008/rebuild (the test candidate) install and
starting a new workspace on XP (not using -data).

java version "1.4.2"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2-b28)
Java HotSpot(TM) Client VM (build 1.4.2-b28, mixed mode)
Comment 6 Markus Keller CLA 2003-10-09 04:08:28 EDT
Yes, it's the entire log (when I click the link again, an equal entry is filed).
I can still reproduce with I20031008_1556, sun jdk1.4.2-b28, WinXP.

It might be important to unzip the eclipse drop into a *fresh* location to avoid
mixing with previous versions.

I found that class QuickStartAction is in package org.eclipse.ui.actions of
project org.eclipse.ui.workbench, which does *not* match the error message and
the link in welcome.xml from project org.eclipse.platform.
Comment 7 Kim Horne CLA 2003-10-10 10:53:07 EDT
My bad.  I misunderstood the problem.

The problem is twofold - the welcome.xml refers to the wrong class and the class
in question does not have a no-arg constructor (required by welcome.xml
actions).  Patches for both forthcoming.
Comment 8 Kim Horne CLA 2003-10-10 11:09:16 EDT
Created attachment 6398 [details]
Patch for org.eclipse.ui.workbench
Comment 9 Kim Horne CLA 2003-10-10 11:09:46 EDT
Created attachment 6400 [details]
Patch for org.eclipse.platform
Comment 10 Douglas Pollock CLA 2003-10-31 11:51:53 EST
This bug was caused by the fix for Bug 39113.  I have committed a fix to
QuickStartAction, as described in Comment #8.  However, I do not have
permissions to modify "welcome.xml" in "org.eclipse.platform".

Sonia: Could you please update "welcome.xml" with the patch found in Comment #9,
and update "feature.map" before the next integration build?  It is a one-line
fix to a fully-qualified class name.  Thank you.
Comment 11 Nick Edgar CLA 2003-11-11 01:05:10 EST
Created attachment 6725 [details]
Revised patch for org.eclipse.platform (post-RCP)

Turns out I don't have commit rights here after all.  Back to Sonia!
I've revised the patch to correspond to the RCP changes.
Comment 12 Nick Edgar CLA 2003-11-12 11:36:52 EST
I've released the change.
Comment 13 Nick Edgar CLA 2003-11-12 11:37:01 EST
Fixed.
Comment 14 Markus Keller CLA 2003-11-21 04:59:16 EST
I20031120: Link doesn't work -- QuickStartAction was on the road again.

Error Nov 21, 2003 10:46:05.338 Unable to load class org.eclipse.ui
org.eclipse.ui.internal.QuickStartAction
Comment 15 Nick Edgar CLA 2003-11-21 09:22:54 EST
Actually, the org.eclipse.platform feature did not get versioned off and 
included in the build.  Sonia, who is supposed to release changes to the 
platform feature plugin?
Comment 16 Sonia Dimitrov CLA 2003-11-21 09:30:53 EST
Whoever makes changes to this should go ahead and release it to the build.
Comment 17 Nick Edgar CLA 2003-11-21 10:14:26 EST
Change released to today's rebuild.