Bug 444397 - Remove CVS dependency from Mylyn features
Summary: Remove CVS dependency from Mylyn features
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.16   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 438297
  Show dependency tree
 
Reported: 2014-09-17 13:33 EDT by Markus Knauer CLA
Modified: 2015-07-16 17:55 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Knauer CLA 2014-09-17 13:33:45 EDT
We've got a request to remove CVS from (most) EPP packages (see bug 438297). 

During my investigation about the feasibility of this request I found out that the Mylyn features org.eclipse.mylyn.cvs and org.eclipse.mylyn.ide_feature define direct and/or indirect dependencies to CVS. Unfortunately (or: fortunately for you...) these features are included in many of the packages and prevent us from removing CVS.

Is it possible to remove the CVS Mylyn integration from those features and move it into a separate feature? I reckon that CVS Mylyn support is not the most-wanted feature any more, and that it would be beneficial for all parties to remove it.
Comment 1 Steffen Pingel CLA 2015-01-06 15:59:58 EST
The org.eclipse.mylyn.cvs feature can easily be removed from EPP packages.

The ide_feature is a bit more tricky: I'm in favor of removing the CVS dependency from that feature in the next Mylyn release. If we do that we should either EOL the CVS integration in Mylyn or create a separate feature for the org.eclipse.mylyn.team.cvs bundle to enable users to still install it.

Sam, what do you think?
Comment 2 Sam Davis CLA 2015-01-06 16:59:17 EST
I'm in favour of creating a separate feature. I realize that usage of CVS is low, but we haven't had to do any maintenance on that integration for years so I think it's justifiable to keep it as long as there is some demand. Also, I hesitate to EOL the CVS integration since I think it is much more robust than any other SCM integration we have (perhaps because the Eclipse CVS integration is more robust than Subclipse and Subversive)...
Comment 3 Markus Knauer CLA 2015-02-05 11:50:52 EST
Any progress here?
Comment 4 Sam Davis CLA 2015-02-05 12:57:01 EST
Well, the bug is assigned to you. Were you planning on making a contribution? If not, please reassign to default and we'll see if we can do this in time for Mars.
Comment 5 Markus Knauer CLA 2015-02-05 14:23:45 EST
I don't know why it was assigned to me... maybe I was dreaming... or clicked the wrong button in the middle of the night...

In any case I don't think I will have the time to work a contribution, but I would be very thankful if you could solve it for us in the Mars timeframe. Many thanks in advance!
Comment 6 Sam Davis CLA 2015-02-05 14:39:54 EST
I can't make any promises, but I'm tentatively putting this on the next milestone.
Comment 7 Markus Knauer CLA 2015-02-05 14:40:43 EST
Thanks, that would be great.
Comment 8 Steffen Pingel CLA 2015-03-17 09:48:43 EDT
Sam, let me know if you want me to take a pass at this.
Comment 9 Steffen Pingel CLA 2015-03-19 11:08:16 EDT
Proposed feature (org.eclipse.mylyn.team.cvs): https://git.eclipse.org/r/44182
Comment 10 Steffen Pingel CLA 2015-03-30 12:44:41 EDT
Sam, did you get a chance to look at the review?
Comment 11 Sam Davis CLA 2015-03-30 13:37:14 EDT
No, I won't have a chance before next week.
Comment 12 Sam Davis CLA 2015-05-04 17:44:11 EDT
Once the change is merged, we should do a snapshot build and verify that installation works as expected.
Comment 13 Steffen Pingel CLA 2015-05-06 03:41:04 EDT
This review adds the feature to the main site: https://git.eclipse.org/r/#/c/47221/.
Comment 14 Steffen Pingel CLA 2015-05-06 05:01:38 EDT
Both changes have been merged.
Comment 15 Sam Davis CLA 2015-05-06 18:52:36 EDT
Great, thanks Steffen.
Comment 16 Sam Davis CLA 2015-07-16 13:14:18 EDT
Steffen, since the CVS client is still available from http://download.eclipse.org/releases/mars, do you think we should add the new feature to mylyn.b3aggrcon?
Comment 17 Steffen Pingel CLA 2015-07-16 17:55:43 EDT
That makes sense to me (although there have been complaints in the past that Mylyn contributes too many visible features).