Bug 44438 - "Team -> Show in resource history" fails on locked files with CVS
Summary: "Team -> Show in resource history" fails on locked files with CVS
Status: RESOLVED DUPLICATE of bug 103374
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 98057 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-10-08 10:11 EDT by Eugene Kuleshov CLA
Modified: 2010-07-22 22:29 EDT (History)
2 users (show)

See Also:


Attachments
Patch to fix synchronization of locked revision (1.38 KB, patch)
2010-07-22 22:03 EDT, Olexiy Buyanskyy CLA
no flags Details | Diff
Use different name for incoming value (1.49 KB, patch)
2010-07-22 22:09 EDT, Olexiy Buyanskyy CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2003-10-08 10:11:25 EDT
When trying to view history on locked files (no matter if file is not locked in 
a branch) cvs history view is not show the actual history for that locked file 
and there are an exception in .log file. This is for Eclipse 3.0 200308281813

!ENTRY org.eclipse.ui 4 4 Oct 08, 2003 09:59:46.220
!MESSAGE Unhandled exception caught in event loop.
!ENTRY org.eclipse.ui 4 0 Oct 08, 2003 09:59:46.220
!MESSAGE 5	locked by: falkgeof;
!STACK 0
java.lang.NumberFormatException: 5	locked by: falkgeof;
	at java.lang.Integer.parseInt(Integer.java:418)
	at java.lang.Integer.<init>(Integer.java:544)
	at org.eclipse.team.internal.ccvs.ui.VersionCollator.getIntSegments
(VersionCollator.java:55)
	at org.eclipse.team.internal.ccvs.ui.VersionCollator.compare
(VersionCollator.java:27)
	at 
org.eclipse.team.internal.ccvs.ui.HistoryTableProvider$HistorySorter.compareColu
mnValue(HistoryTableProvider.java:185)
	at 
org.eclipse.team.internal.ccvs.ui.HistoryTableProvider$HistorySorter.compare
(HistoryTableProvider.java:170)
	at org.eclipse.jface.viewers.ViewerSorter$1.compare
(ViewerSorter.java:169)
	at java.util.Arrays.mergeSort(Arrays.java:1176)
	at java.util.Arrays.mergeSort(Arrays.java:1183)
	at java.util.Arrays.sort(Arrays.java:1123)
	at org.eclipse.jface.viewers.ViewerSorter.sort(ViewerSorter.java:167)
	at org.eclipse.jface.viewers.StructuredViewer.getSortedChildren
(StructuredViewer.java:557)
	at org.eclipse.jface.viewers.TableViewer.internalRefresh
(TableViewer.java:447)
	at org.eclipse.jface.viewers.TableViewer.internalRefresh
(TableViewer.java:431)
	at org.eclipse.jface.viewers.StructuredViewer$7.run
(StructuredViewer.java:856)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection
(StructuredViewer.java:796)
	at org.eclipse.jface.viewers.StructuredViewer.refresh
(StructuredViewer.java:854)
	at org.eclipse.jface.viewers.StructuredViewer.refresh
(StructuredViewer.java:816)
	at org.eclipse.jface.viewers.TableViewer.inputChanged
(TableViewer.java:398)
	at org.eclipse.jface.viewers.ContentViewer.setInput
(ContentViewer.java:238)
	at org.eclipse.jface.viewers.StructuredViewer.setInput
(StructuredViewer.java:983)
	at org.eclipse.team.internal.ccvs.ui.HistoryView.showHistory
(HistoryView.java:577)
	at org.eclipse.team.internal.ccvs.ui.actions.ShowHistoryAction$1.run
(ShowHistoryAction.java:68)
	at org.eclipse.team.internal.ccvs.ui.repo.RepositoryManager.run
(RepositoryManager.java:802)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction$1.run
(CVSAction.java:241)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction$2.run
(CVSAction.java:250)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:84)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run
(CVSAction.java:247)
	at org.eclipse.team.internal.ccvs.ui.actions.ShowHistoryAction.execute
(ShowHistoryAction.java:63)
	at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run
(CVSAction.java:68)
	at org.eclipse.ui.actions.ActionDelegate.runWithEvent
(ActionDelegate.java:71)
	at org.eclipse.ui.internal.PluginAction.runWithEvent
(PluginAction.java:253)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection
(ActionContributionItem.java:529)
	at org.eclipse.jface.action.ActionContributionItem.access$4
(ActionContributionItem.java:482)
	at org.eclipse.jface.action.ActionContributionItem$6.handleEvent
(ActionContributionItem.java:454)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:847)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2188)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1878)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2036)
	at org.eclipse.ui.internal.Workbench.run(Workbench.java:2019)
	at org.eclipse.core.internal.boot.InternalBootLoader.run
(InternalBootLoader.java:858)
	at org.eclipse.core.boot.BootLoader.run(BootLoader.java:461)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:295)
	at org.eclipse.core.launcher.Main.run(Main.java:751)
	at org.eclipse.core.launcher.Main.main(Main.java:587)
Comment 1 Jean-Michel Lemieux CLA 2004-06-11 16:50:47 EDT
Post 3.0
Comment 2 Eugene Kuleshov CLA 2004-07-23 11:49:03 EDT
Any chance to get this feature implemented in 3.1 release?
Comment 3 Jean-Michel Lemieux CLA 2004-12-13 22:29:33 EST
Can you provide a patch?
Comment 4 Eugene Kuleshov CLA 2004-12-13 22:48:01 EST
Unfortuantely I can't. Sorry.
Comment 5 Michael Valenta CLA 2005-05-27 11:17:32 EDT
There is currently no plan to address this item.
Comment 6 Michael Valenta CLA 2005-06-02 10:58:49 EDT
*** Bug 98057 has been marked as a duplicate of this bug. ***
Comment 7 Michael Valenta CLA 2005-07-18 15:23:58 EDT
Reopening
Comment 8 Michael Valenta CLA 2005-07-18 15:24:09 EDT

*** This bug has been marked as a duplicate of 103374 ***
Comment 9 Olexiy Buyanskyy CLA 2010-07-22 22:03:54 EDT
Created attachment 175034 [details]
Patch to fix synchronization of locked revision

I found that this bug is critical for our company. Please review my patch.
That is easy to reproduce bug.
You need just lock revision with

cvs admin -lbranch file

and try to compare locked revision with another revision.
Comment 10 Olexiy Buyanskyy CLA 2010-07-22 22:09:47 EDT
Created attachment 175035 [details]
Use different name for incoming value

See my description about patch in previous comment. Second patch replace first one
Comment 11 Olexiy Buyanskyy CLA 2010-07-22 22:16:58 EDT
Oh I discovered that this bug marked as FIXED. 
But it was not fixed 100%. setRevision() function was missed in the fix. I was able to reproduce it with eclipse 3.6.
Should I create new bug?
Comment 12 Olexiy Buyanskyy CLA 2010-07-22 22:29:37 EDT
I went ahead and created new bug 320686 with the same patch attached