Bug 444216 - [Model] Toolbar button shown twice after killing eclipse process
Summary: [Model] Toolbar button shown twice after killing eclipse process
Status: CLOSED DUPLICATE of bug 509371
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 549902
  Show dependency tree
 
Reported: 2014-09-16 04:51 EDT by Thomas Schulze zur Wiesch CLA
Modified: 2020-07-23 07:19 EDT (History)
5 users (show)

See Also:


Attachments
Sample plug-in (8.74 KB, application/x-zip-compressed)
2014-09-16 04:51 EDT, Thomas Schulze zur Wiesch CLA
no flags Details
Screenshot showing the same button two times (42.06 KB, image/png)
2014-09-16 04:52 EDT, Thomas Schulze zur Wiesch CLA
no flags Details
Workbench.xmi containing the entries leading to buttons shown twice (264.20 KB, application/octet-stream)
2014-09-16 04:53 EDT, Thomas Schulze zur Wiesch CLA
no flags Details
Screenshot of actions that multiply (14.53 KB, image/png)
2015-09-23 03:53 EDT, Markus Duft CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schulze zur Wiesch CLA 2014-09-16 04:51:18 EDT
Created attachment 247101 [details]
Sample plug-in

Dear Eclipse team,

we have problems with items we contribute to the toolbar "org.eclipse.search.searchActionSet". After some time the contributed items show up multiple times (see screenshot). 

We analyzed the issue and found out how to reproduce:
1. use the example plugin project attached to this bug report (contains a simple sample plug-in which contributes one toolbar button to "org.eclipse.search.searchActionSet")
2. add this plugin to a blank Eclipse installation (tested with: Luna Release 4.4.0 - Build id: 20140612-0600 with JDT - got it from http://www.eclipse.org/downloads/download.php?file=/technology/epp/downloads/release/luna/R/eclipse-standard-luna-R-win32-x86_64.zip)
3. wait for eclipse saving the workbench state (modifies \.metadata\.plugins\org.eclipse.e4.workbench\workbench.xmi in your workspace and writes children to node with elementId "org.eclipse.search.searchActionSet" see attachment workbench.xmi)
  - we set the save intervals for workbench and workspace to 1 minute and changed something in the view layout (moving one view to another area) to make Eclipse safe the workbench state
4. now kill the eclipse process (if you close eclipse the normal way, workbench.xmi gets cleaned up)
5. start eclipse again
6. bug: contributed toolbar button is shown twice
7. if you repeat this procedure, you will end up with even more toolbar buttons

We only have the problem with this particular toolbar.

Could you please look into why the toolbar button is shown twice after killing eclipse?

If you need more information, please let me know.

Best regards,
Thomas
Comment 1 Thomas Schulze zur Wiesch CLA 2014-09-16 04:52:13 EDT
Created attachment 247102 [details]
Screenshot showing the same button two times
Comment 2 Thomas Schulze zur Wiesch CLA 2014-09-16 04:53:15 EDT
Created attachment 247103 [details]
Workbench.xmi containing the entries leading to buttons shown twice
Comment 3 Markus Duft CLA 2015-09-23 03:52:24 EDT
we have the same problem with actions that we contributed ourselves to the IDE.
Comment 4 Markus Duft CLA 2015-09-23 03:53:10 EDT
Created attachment 256778 [details]
Screenshot of actions that multiply
Comment 5 Eclipse Genie CLA 2020-03-23 17:06:44 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Markus Duft CLA 2020-03-24 03:34:40 EDT
The issue occurs just the same since years. It is still important for us, as it currently forces devs to delete workbench.xmi from time to time to reset everything (including all views, etc.).
Comment 7 Andreas Pakulat CLA 2020-05-05 10:00:31 EDT
We received a report from one of our customers running into what appears to be the same issue. I also managed to trigger a duplication using that workbench.xmi file once, but so far failed to trigger it a second time.

Things I did in our Eclipse-based IDE include: Opening an editor, moving it to split it off the existing editor tabs, closing a view, switching perspectives and stepping through an execution. Finally I killed Eclipse via Ctrl+C. 

Unfortunately I cannot easily share the xmi file at the moment since it contains tons of user-data that is not easily replaced in an automatic fashion.
Comment 8 Andreas Pakulat CLA 2020-05-05 10:01:25 EDT
PS: This was seen on Linux in our case.
Comment 9 Lars Vogel CLA 2020-05-11 15:53:50 EDT
Please reopen if the problem still persists.
Comment 10 Markus Duft CLA 2020-05-12 02:16:35 EDT
The problem still persists
Comment 11 Lars Vogel CLA 2020-06-03 05:45:27 EDT
Rolf, something for you?
Comment 12 Rolf Theunissen CLA 2020-06-03 05:57:22 EDT
Difference between the auto-saved and save-after-shutdown in workbench.xmi are tracked in Bug 549902.

Manually copy the workbench.xmi when it is auto-saved, and compare it to the after-shutdown version. That should give you a clue why this occurs.
Comment 13 Rolf Theunissen CLA 2020-06-03 14:12:13 EDT
Which version of Eclipse are you using? This bug looks a lot like a duplicate of Bug 509371 which should be fixed.
Comment 14 Lars Vogel CLA 2020-07-23 07:19:20 EDT
Marking as dup of Bug 509371

*** This bug has been marked as a duplicate of bug 509371 ***