Bug 443545 - add preferences to support flux URL and authentication information
Summary: add preferences to support flux URL and authentication information
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Flux (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-08 19:00 EDT by Martin Lippert CLA
Modified: 2019-02-21 15:36 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lippert CLA 2014-09-08 19:00:20 EDT
We need to add a preference page that allows you to specify the Flux URL you wanna use together with the Eclipse URL as well as authentication information, the GitHub token, for example.

Probably we can also add support for multiple FLux URLs, so that you can connect to multiple Flux systems and choose per project, to which Flux to connect your project to.
Comment 1 Alex Boyko CLA 2014-09-15 20:08:47 EDT
Fixed. There is a preference page in the Preferences (find Flux in the root children). The page allows to set:
Flux Server URL
User GitHub ID
User GitHub token

On Apply or OK user would be asked to restart the workbench for new connection settings to take effect.
If any of the 3 Flux server connection settings are via command line arguments or env variables then the page shows up in read-only mode and displays the current Flux server connection settings.
Comment 2 Martin Lippert CLA 2014-09-16 02:45:49 EDT
forgot to push? Don't see anything in the repo yet...
Comment 3 Alex Boyko CLA 2014-09-16 09:35:57 EDT
Yes, indeed. Thanks :-)
Just pushed my changes in now. Every time i commit something and need to do a pull first to sync in the latest changes I don't notice that I need to do a pull before the push...
Anyway, should be in now.
Comment 4 Alex Boyko CLA 2014-09-16 13:42:00 EDT
Delivered additional fix for this. Turns out that workbench restart doesn't save preferences changes until preferences dialog OK button is not pressed or apply, hence changes to preferences were never persisted.
Added saving of preferences before restarting