Bug 44354 - [KeyBindings] By default, Delete action not bound in key service
Summary: [KeyBindings] By default, Delete action not bound in key service
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0 M8   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 57618 (view as bug list)
Depends on: 46589
Blocks:
  Show dependency tree
 
Reported: 2003-10-07 16:01 EDT by Michael Valenta CLA
Modified: 2004-04-07 10:33 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2003-10-07 16:01:23 EDT 
We have modified the new sync view to use the key binding service for Delete.
By default, the Delete action is not bound. It should be bound to the delete 
key I should think.

Also, this is a bit confusing for the user since every other view captures the 
key directly so delete still works. Are other views going to switch to use the 
service for delete?
Comment 1 Douglas Pollock CLA 2003-10-07 16:50:45 EDT 
Please see Bug 43851 to track our progress on motivating other teams (and our
own) to stop binding to keys directly.  You are on the righteous path, and
surely you will be rewarded.  :)

If the binding the delete action to "Delete" causes problems, we might be able
to use the fix for Bug 43161 to facilitate a migration path.  By specifying
"Delete" as "out-of-order", we would allow people binding directly to get the
key first.  After that, global key binding processing would kick in.
Comment 2 Douglas Pollock CLA 2003-12-05 13:28:03 EST 
"Delete" is bound in the new key configuration ("Standard (3.0) - NEW!").  While
it is not certain that this will become the new default, it seems likely at this
point.

If for some reason this key is still unbound when M6 comes around, I will
re-open this bug.  For now, I'm just cleaning shop.  ;)
Comment 3 Douglas Pollock CLA 2003-12-17 10:27:04 EST 
Moving this to M7, so I'll take another look to make sure this is still the case.
Comment 4 Douglas Pollock CLA 2004-02-12 09:52:26 EST 
We are deferring the new key configuration.  I'll look at binding "Delete" in
the old key configuration.
Comment 5 Douglas Pollock CLA 2004-02-13 16:18:08 EST 
Fixed in CVS.  It is now bound in the default key configuration.
Comment 6 Douglas Pollock CLA 2004-02-20 10:54:03 EST 
This causes problems with other keys.  Basically, in a StyledText widget, we 
want "DEL" to arrive at the widget.  It is impossible to accurately tell which 
should take precedence (i.e., there is no clear place to insert myself during 
the event processing). 
 
As a result, I'm going to have to go back on my word and ask you to implement 
a key listener yourself.
Comment 7 Douglas Pollock CLA 2004-02-20 10:55:16 EST 
Sorry about this.  Could you please attach a key listener to the sync view?  
Thanks.
Comment 8 Douglas Pollock CLA 2004-02-25 15:20:30 EST 
Back and forth we go....
Comment 9 Douglas Pollock CLA 2004-02-25 15:20:54 EST 
Markus pointed out something that let me see a way of doing this.  It's done 
and in CVS.
Comment 10 Douglas Pollock CLA 2004-03-24 15:08:42 EST 
While verifying this bug, Bug 56007 was detected. 
 
Verified in I200403240800 in two ways. 
1.) Changed one file, opened the synchronize view and press delete.  I was 
prompted to delete resources. 
2.) Pressed the "DEL" key while focus was in the editor (with debugging on), 
and the workbench keyboard reports that "DEL" is bound to 
"org.eclipse.ui.delete".
Comment 11 Douglas Pollock CLA 2004-04-07 10:33:56 EDT 
*** Bug 57618 has been marked as a duplicate of this bug. ***