Bug 443506 - remove macosx 32bit fragment from rcp feature
Summary: remove macosx 32bit fragment from rcp feature
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: 4.5 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 441691
  Show dependency tree
 
Reported: 2014-09-08 10:11 EDT by David Williams CLA
Modified: 2014-09-26 07:06 EDT (History)
2 users (show)

See Also:

Attachments
patch to remove 32 bit mac fragments from e4.rcp feature. (2.33 KB, patch)
2014-09-08 10:11 EDT, David Williams CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-09-08 10:11:22 EDT 
Created attachment 246826 [details]
patch to remove 32 bit mac fragments from e4.rcp feature.

I hope everyone knows we are removing the 32 bit Macosx version of Eclipse from Mars. 

Here's a couple of changes need in the e4.rcp feature to "remove it" from there. 

I've marked as "blocking", since given the other changes I've already made, our next build will fail unless these references to now non-existent fragments are removed. 

There could be other spots similar to this one, so would appreciate a "quick response" ... so I can do some more "test builds" today. 

Thanks,
Comment 1 David Williams CLA 2014-09-08 13:33:00 EDT 
Also, I forgot to include launcher in patch ... 

If you don't mind just "taking from here", please also remove the fragment: 

   <plugin
         id="org.eclipse.equinox.launcher.gtk.solaris.x86"
         os="solaris"
         ws="gtk"
         arch="x86"
         download-size="0"
         install-size="0"
         version="0.0.0"
         fragment="true"/>
Comment 2 Markus Keller CLA 2014-09-09 06:39:25 EDT 
Removed cocoa.macosx and gtk.solaris.x86 with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=43d9d327749daabae6aa986d8af1416cf4ae0bd3

I've also updated the version of the org.eclipse.e4.rcp feature to 1.3.200: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f3d1710a24c3bf2cf200a242c731952717e09b02
Comment 3 Markus Keller CLA 2014-09-09 06:59:40 EDT 
I've reverted the gtk.solaris.x86 removal for now: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b41cfe6d20991db21fba9c6f76c239a2b1fd1d02

AFAICS, this also needs to be synchronized with changes in eclipse.platform.releng.aggregator, and I still see that platform mentioned there in several places.
Comment 4 David Williams CLA 2014-09-09 11:51:37 EDT 
(In reply to David Williams from comment #1)
> Also, I forgot to include launcher in patch ... 
> 
> If you don't mind just "taking from here", please also remove the fragment: 
> 
>    <plugin
>          id="org.eclipse.equinox.launcher.gtk.solaris.x86"
>          os="solaris"
>          ws="gtk"
>          arch="x86"
>          download-size="0"
>          install-size="0"
>          version="0.0.0"
>          fragment="true"/>

To be sure it's clear, this "solaris" fragment removal was one big "typo" ... we are not removing solarix.x86 right now. Probably next release?
Comment 5 Lars Vogel CLA 2014-09-09 12:27:21 EDT 
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=36a46338c0ea76f560d99e0d26f56d777fcbc08e removes the Mac port to fix the Fixed Gerrit platform.ui trigger
Comment 6 Lars Vogel CLA 2014-09-09 12:29:38 EDT 
(In reply to Markus Keller from comment #3)
> I've reverted the gtk.solaris.x86 removal for now:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=b41cfe6d20991db21fba9c6f76c239a2b1fd1d02
> 

This did not only revert the gtk.solaris.x86 removal, my commit did remove the mac 32 again from the feature.
Comment 7 Lars Vogel CLA 2014-09-26 07:06:14 EDT 
.