Bug 443294 - [EditorMgmt] No functionality to disable split editor feature in Luna
Summary: [EditorMgmt] No functionality to disable split editor feature in Luna
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 443292 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-04 06:24 EDT by Rahul Jaiswal CLA
Modified: 2014-09-09 09:36 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rahul Jaiswal CLA 2014-09-04 06:24:10 EDT
In my eclipse application I have customized editors using the eclipse editor and when migrating to Luna our editors are not working properly due to split editor feature. I tried to disable the split editor feature but didn't get any success. Is there any feature provided to have the default editor behavior without split editor feature in Eclipse Luna. If not please introduce some way to disable the split editor functionality.
Comment 1 Vikas Chandra CLA 2014-09-04 06:58:35 EDT
Moving to Platform UI for comments
Comment 2 Paul Webster CLA 2014-09-04 08:57:03 EDT
By split editor you mean CTRL+SHIFT+_ (splitting one editor, as opposed to dragging an editor into another stack)?

Are you contributing to an Eclipse IDE, or do you have an Eclipse RCP?

PW
Comment 3 Rahul Jaiswal CLA 2014-09-04 09:18:55 EDT
Yes, by split editor I mean CTRL+SHIFT+_.

No, I am not contributing to Eclipse IDE, We are having our own product using Eclipse RCP.
Comment 4 Curtis Windatt CLA 2014-09-04 09:20:27 EDT
*** Bug 443292 has been marked as a duplicate of this bug. ***
Comment 5 Paul Webster CLA 2014-09-04 10:44:58 EDT
Your RCP app can add a "delete" keybinding for the 2 split editor bindings.  See http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fextension-points%2Forg_eclipse_ui_bindings.html for information on the org.eclipse.ui.bindings extension point.

PW
Comment 6 Paul Webster CLA 2014-09-04 10:46:24 EDT
See http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui/plugin.xml#n727 for the current definitions of those bindings.

PW
Comment 7 Rahul Jaiswal CLA 2014-09-05 02:00:19 EDT
Paul,

Sorry, but I could not get what you mean by "delete" keybinding. If from "delete" keybinding you mean defining all split editor keybindings without any 'commandId', then I already tried that solution and it works, but problem occurs if I or someone provides a new keybinding  for horizontal/vertical split editors under 'Keys' from 'Preferences' page, then the split feature starts working again for those newly defined keys.

The other solution I tried are:

1) By providing my own context, command and handler.
2) By providing my own scheme, command and handler.

In both the solution same problem occurs as I defined above.

The only solution which works fine is if I use the same command ID as used by eclipse, which is not a eclipse recommended way as it goes for conflicting handlers.
Comment 8 Paul Webster CLA 2014-09-05 06:22:02 EDT
(In reply to Rahul Jaiswal from comment #7)
> Paul,
> 
> Sorry, but I could not get what you mean by "delete" keybinding. If from
> "delete" keybinding you mean defining all split editor keybindings without
> any 'commandId', then I already tried that solution and it works, but
> problem occurs if I or someone provides a new keybinding  for
> horizontal/vertical split editors under 'Keys' from 'Preferences' page, then
> the split feature starts working again for those newly defined keys.

Eclipse is very amenable to additions but not deletions.  If someone is determined to add back the split editor command they can.  But if you delete the keybinding it won't work out of the box.  If you add a note to your RCP app that split editor won't work correctly, then why would people go to the trouble to add it back?

PW
Comment 9 Rahul Jaiswal CLA 2014-09-09 09:36:30 EDT
Paul,

Thanks for the suggestion.
As this split feature get available by default for the editor in Luna RCP Application and there is no option to avoid this feature if someone doesn't needed for the editors used only for graphical purpose like us. 

So, it will be useful if there is some kind of flag available, using which user can easily turn on/off split behavior feature for the editors if not needed.