Community
Participate
Working Groups
While navigating trough the comments in the compare navigator view, I cannot reach all comments when there is some comments on the right and left side at the same line. Scenario: Comments at (SIDE and line) (LEFT 1) , (LEFT 10), (LEFT 20), (RIGHT 10), (RIGHT 20) Currently: Moving forwards: (LEFT 1 ) - > (LEFT 10) -> (LEFT 20) and loop to (LEFT 1) missing (RIGHT 10) and (RIGHT 20) Moving Backwards:( LEFT 1) -> (RIGHT 20) -> ( RIGHT 10) -> loop back to (LEFT 1) missing (LEFT 10) and (LEFT 20) Needs: Moving forwards: (LEFT 1) - > (RIGHT 10) -> (LEFT 10) -> (RIGHT 20) -> (LEFT 20) and loop to (LEFT 1) Moving Backwards: (LEFT 1) -> (LEFT 20) -> (RIGHT 20 )-> (LEFT 10) -> (RIGHT 10) -> loop back to (LEFT 1)
I can reproduce the problem when moving forward but when moving backward it goes through all the comments, although when there are comments on both sides on the same line, it shows the right comment first.
I just pushed a modification and all comments are reached: Left and Right Gerrit review: https://git.eclipse.org/r/#/c/31918/
I found some case where there was a potential for error, will fix it and push it tomorrow. At the same time, I will look at the test cases
Guys, I'm going to go ahead and take over this review and finish it up. Let me know if that's a problem.
