Bug 439704 - ExternalBrowserInstance.openURL(...) should indicate error if external browser executable not found
Summary: ExternalBrowserInstance.openURL(...) should indicate error if external browse...
Status: CLOSED DUPLICATE of bug 486298
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2014-07-16 08:32 EDT by Andreas Sewe CLA
Modified: 2016-01-21 16:07 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2014-07-16 08:32:33 EDT
The problem is best demonstrated as follows:

  - Go to the "General > Web Browser" preferences
  - "Use external browers"
  - Pick an entry other than "Default system web browser"
  - Click "Edit..."
  - Enter a non-existent "Location"
  - Go to "About Eclipse" and click on any link there

Nothing happens. Under the hood, the problem seems to be that ExternalBrowserInstance.openURL(...) performs (under Mac OS X) a 

 open -a $location $url

which *does* execute a process, namely open. Hence, Runtime.getRuntime().exec(...) doesn't fail.

However, the open process does fail. Maybe one could properly react to its return code (1, if $location doesn't exist).

This would enable, e.g., to fall back to the default system browser if an explicitly configured has configuration problems like a non-existent configuration (e.g., after a browser uninstall).
Comment 1 Johannes Dorn CLA 2014-07-18 06:01:35 EDT
The fix has been merged.
Comment 2 Johannes Dorn CLA 2014-07-18 06:03:40 EDT
I am very sorry, I meant to resolve another bug.
I haven't provided or merged any fix for this one.
Comment 3 Brian de Alwis CLA 2016-01-21 16:07:37 EST
Came across this after the fact.  Fixed reporting of open(1) failure in bug 463949 and bug 475775, and fixed invalid location in 486298.

*** This bug has been marked as a duplicate of bug 486298 ***