Bug 439189 - Products need version updated to 4.4.1 in maintenance
Summary: Products need version updated to 4.4.1 in maintenance
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4.1   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 439154
Blocks: 436736
  Show dependency tree
 
Reported: 2014-07-08 22:20 EDT by David Williams CLA
Modified: 2015-06-09 14:13 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-07-08 22:20:20 EDT
+++ This bug was initially created as a clone of Bug #439154 +++

Bug 439154 reminded me we need to update the "product versions" in R4_4_maintenance branch to 4.4.1. This is important in two places, for each "product" in "org.eclipse.platform.releng.tychoeclipsebuilder": 

1. Is the product definition itself. Pretty obvious. 

2. And for reasons I do not quite recall, this is one of the few places where the "artifact id" in the POM file needs to be updated also to 4.4.1. Related to some thing about the way Tycho computes "version number" for Mac's plist.info or something kind of obscure like that. I bet Thanh remembers (he's the one who told me in Kepler stream).
Comment 1 David Williams CLA 2014-07-08 22:33:29 EDT
This is the commit covering all "products" in eclipsetychobuilder, both product definitions, and pom artifact IDs. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_4_maintenance&id=e7465adb24bea1967fa61ea347eaacf52615bdba

Thanh, if you could recall the reason why we needed to update the artifact id, or recall enough to search for original bug :) ... that'd be great to document here. 

But, another question for you. While doing this change, I noticed we do not have a "version number" for the "eclipse-junit-tests" (thought, we did in the distant past, and at some point it was removed). 

I'm wonder if you recall why? I'm guessing it's related to it being of "type" eclipse-repository instead of a typical "artifact" in the Maven sense? 

And, wondering if you recall if if was harmful to have one ... or, just not needed? 

I'm partially asking out of curiosity, but also because our "main" repository does have a version, and am wonder if that can/should be removed too? See 
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/pom.xml#n22

Thanks,
Comment 2 David Williams CLA 2014-07-08 23:20:47 EDT
I made one typo, and corrected it here

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_4_maintenance&id=84a5542a5a9921642218e0efa609c4e2b93cb55e

And it was a very lucky typo, since that is the place where I documented why we need to update the artifact ID, and documented the original bug 423677 which "explains everything" ... well, at least the questions I asked above. (It has to do with the "metadata" that is written to content.jar or artifacts.jar, so only "shows up" in some circumstances of "update" or "install" ... such as if only Platform was installed, that product version would initially appear correct, but after installing Eclipse SDK on top of it, the product id would then show up as "4.4.0" in some places (but not others). 

In any case, I think we're set for our first M-build Wednesday morning.