Bug 438901 - Style PASSWORD | READ_ONLY without BORDER displays plain text password
Summary: Style PASSWORD | READ_ONLY without BORDER displays plain text password
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: 4.4.1   Edit
Assignee: Niraj Modi CLA
QA Contact:
URL:
Whiteboard:
Keywords: security
Depends on:
Blocks:
 
Reported: 2014-07-04 03:42 EDT by Frank Jakop CLA
Modified: 2014-08-28 06:15 EDT (History)
3 users (show)

See Also:
lshanmug: review+

Attachments
Text controls with different styles (47.27 KB, image/jpeg)
2014-07-04 03:42 EDT, Frank Jakop CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Jakop CLA 2014-07-04 03:42:14 EDT 
Created attachment 244812 [details]
Text controls with different styles

Using this version of SWT

Bundle-SymbolicName: org.eclipse.swt.win32.win32.x86; singleton:=true
Bundle-Version: 3.100.1.v4234e

we are encountering a strange behaviour of the Text-Control.

Whenever you set the styles READ_ONLY and PASSWORD *without* setting BORDER, the password is displayed in plain text.
Comment 1 Niraj Modi CLA 2014-07-04 04:25:33 EDT 
Issue can be reproduced by modifying Snippet346 with for Text field with SWT.PASSWORD | SWT.READ_ONLY style, targeting for 4.5
Comment 2 Niraj Modi CLA 2014-07-08 08:15:01 EDT 
Issue also seen with SWT ControlExample:
1. Launch ControlExample, go to "Text" tab
2. Make the style selection as: SWT.SINGLE | SWT.READ_ONLY | SWT.PASSWORD
3. The text on the left will becomes readable.

Resolution of the bug:
Multi-line text control is not suitable for Text widget for PASSWORD | READ_ONLY style.
Fix the problem & changed pushed to master through below patch:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7b8b59f77ed87d96d9ebb10e1635504f88c3e8ea
Comment 3 Niraj Modi CLA 2014-08-05 08:57:49 EDT 
Verified the fix in I20140804-2000 build.
Comment 4 Niraj Modi CLA 2014-08-06 05:47:17 EDT 
Reopening this bug for back-port to 4.4.1 release.
Lakshmi, for your review.
Comment 5 Niraj Modi CLA 2014-08-06 09:11:15 EDT 
Thanks for the quick review Lakshmi.
Back-ported the change to 'R4_4_maintenance' branch via below patch:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?h=R4_4_maintenance&id=7ae87fa2369a173c86775bf851b6afd6ea5a77e3
Comment 6 Niraj Modi CLA 2014-08-28 06:15:17 EDT 
Verified the fix in M20140827-1200 build