Bug 438887 - Remove context menu entry "Restore from local History"
Summary: Remove context menu entry "Restore from local History"
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5 M2   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL: https://git.eclipse.org/r/29434
Whiteboard:
Keywords:
Depends on:
Blocks: 438356
  Show dependency tree
 
Reported: 2014-07-03 17:05 EDT by Lars Vogel CLA
Modified: 2014-08-04 08:13 EDT (History)
3 users (show)

See Also:
mistria: review?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-07-03 17:05:43 EDT
This entry is also available under the "Replace with" menu entry.
Comment 1 Mickael Istria CLA 2014-07-03 18:16:43 EDT
Suggested change: https://git.eclipse.org/r/29434
Comment 2 Paul Webster CLA 2014-07-04 15:24:07 EDT
-1

Create a new project.  Create a file, save a couple of times.  Delete the file.

Right-click on the project.  There is no Replace With menu.

PW
Comment 3 Mickael Istria CLA 2014-07-07 04:11:11 EDT
(In reply to Paul Webster from comment #2)
> -1
> Create a new project.  Create a file, save a couple of times.  Delete the
> file.
> Right-click on the project.  There is no Replace With menu.

So shouldn't we show the "Replace With" menu on the project as well?
Or shouldn't we refine the visibility of the "Restore from local history" menu to projects only?
Comment 4 Lars Vogel CLA 2014-07-07 04:14:27 EDT
(In reply to Mickael Istria from comment #3)
> (In reply to Paul Webster from comment #2)
> > -1
> > Create a new project.  Create a file, save a couple of times.  Delete the
> > file.
> > Right-click on the project.  There is no Replace With menu.
> 
> So shouldn't we show the "Replace With" menu on the project as well?

+1 this sounds like the right approach to me.
Comment 5 Mickael Istria CLA 2014-08-04 07:24:13 EDT
Gerrit patch updated so it should support use-case of comment #2.
Comment 6 Dani Megert CLA 2014-08-04 08:13:31 EDT
Replace With is used to *replace* something that already exists. I would never look for the restore option in the Replace With menu.