Bug 438096 - DefaultBindingResolver is too generic
Summary: DefaultBindingResolver is too generic
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on: 424550
Blocks:
  Show dependency tree
 
Reported: 2014-06-24 15:29 EDT by Dawid Pakula CLA
Modified: 2020-05-14 10:17 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2014-06-24 15:29:56 EDT
Available for DOM AST only, and with very generic implementation. 

If I need IType from MethodInvocation:
a) Traverse compiler ast to find IContext and corresponing compiler ASTNode
b) Run TI, with all performance problems
c) Cache it for concrete compiler AST node

If IMethod/IField is also required, collect all fields and methods by PHPModelUtils

JDT works different:
a) Binding resolver, always contain map DOMAst => CompilerAST (built while AST convert)
b) Contexts are not required, so probably we should build and cache context while ast convert
c) Bindings are also cached on corresponding AST nodes and reused later  (here we need small DLTK modification), maybe will be possible to collect it by IEvaluationStatisticsRequestor