Bug 436344 - [Tests] Convert Eclipse platform.ui test suite to JUnit 4
Summary: [Tests] Convert Eclipse platform.ui test suite to JUnit 4
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.7 M7   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on: 430468 443094 443391 443804 443806 443904 448832 450209 457870 474132 474274 474275
Blocks: 493776
  Show dependency tree
 
Reported: 2014-06-02 05:43 EDT by Lars Vogel CLA
Modified: 2017-05-08 04:50 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-06-02 05:43:05 EDT 
I suggest to convert the Eclipse platform.ui tests to JUnit 4.
Comment 1 Lars Vogel CLA 2014-07-01 09:42:24 EDT 
I plan to update the unit tests by project. David, is their something to consider from your build perspective?
Comment 2 David Williams CLA 2014-07-01 09:44:54 EDT 
(In reply to Lars Vogel from comment #1)
> I plan to update the unit tests by project. David, is their something to
> consider from your build perspective?

no, not that I can think of. (Technically, they all run under JUnit 4, I believe ... it's just they are using the "JUnit 3 compatible" methods ... I think.
Comment 3 Lars Vogel CLA 2014-09-02 08:39:37 EDT 
(In reply to David Williams from comment #2)
> no, not that I can think of. (Technically, they all run under JUnit 4, I
> believe ... it's just they are using the "JUnit 3 compatible" methods ... I
> think.

If will give it a try with Bug 430468. I hope I don't break anything.
Comment 4 Simon Scholz CLA 2014-09-07 11:17:34 EDT 
Also moved org.eclipse.e4.ui.bindings.tests to JUnit 4

https://git.eclipse.org/r/#/c/32997/
Comment 5 Lars Vogel CLA 2014-09-10 17:04:03 EDT 
(In reply to Simon Scholz from comment #4)
> Also moved org.eclipse.e4.ui.bindings.tests to JUnit 4
> 
> https://git.eclipse.org/r/#/c/32997/

Thanks. Applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=acbd7ae0a7a746f6394805c7c56f46a64c2132db
Comment 6 David Williams CLA 2014-09-12 12:44:43 EDT 
(In reply to Lars Vogel from comment #1)
> I plan to update the unit tests by project. David, is their something to
> consider from your build perspective?

I have thought of a *possible* complication ... and that is if there is something about running today's (4.4) tests, on Eclipse 3.8, for performance testing. My guess is that there is not, but ... I'd be the last to know. But that is something we want to do eventually. If there's any easy way for you tell if that'd be an issue, that'd be great. Even then, there's only a small set of test suites that have viable performance targets, see 442455 comment 4.

Should know more in "a week or two".
Comment 7 Lars Vogel CLA 2014-09-17 11:55:57 EDT 
(In reply to David Williams from comment #6)
> (In reply to Lars Vogel from comment #1)
> > I plan to update the unit tests by project. David, is their something to
> > consider from your build perspective?
> 
> I have thought of a *possible* complication ... and that is if there is
> something about running today's (4.4) tests, on Eclipse 3.8, for performance
> testing. My guess is that there is not, but ...

I would also assume no, but the only way to know for sure is to wait once your setup is ready.
Comment 8 Lars Vogel CLA 2017-05-08 04:50:06 EDT 
Most of the test suites have been migrated. Marking as closed, the few missing test suites will be handled by individual bugs.