Bug 436069 - Sirius should not allow the use of tools and mappings out of a Layer in the Diagram dialect
Summary: Sirius should not allow the use of tools and mappings out of a Layer in the D...
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 447702 435879
Blocks: 441709 450487
  Show dependency tree
 
Reported: 2014-05-28 10:29 EDT by Maxime Porhel CLA
Modified: 2015-03-30 08:36 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2014-05-28 10:29:59 EDT 
Tools and Mappings creation and reuse on a DiagramDescription have been disabled in Bug 435879. 

The "without layer" mode code should be removed.
The Tools/Mappings children of a DiagramDescription or reused from it should be moved to the default layer thanks to an auto-migration.
The corresponding reference in the metamodel should be removed.
Comment 1 Maxime Porhel CLA 2014-10-17 09:34:09 EDT 
*** Bug 447702 has been marked as a duplicate of this bug. ***
Comment 2 Maxime Porhel CLA 2014-10-17 09:34:41 EDT 
See additional information on Bug 447702
Comment 3 Benjamin Grouhan CLA 2015-03-30 08:36:09 EDT 
I have added a constraint (org.eclipse.sirius.diagram.tools.internal.validation.description.constraints.ExistingDefaultLayerConstraint) to validate that each diagram has a default layer, but it will be useless when the "without layer" mode will be removed. More accurately, this constraint should be removed when the cardinality of the default layer reference will become [1..1].