Bug 435879 - Specifier should not have the possibility to create unsupported Diagram structure
Summary: Specifier should not have the possibility to create unsupported Diagram struc...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Maxime Porhel CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
: 422683 (view as bug list)
Depends on:
Blocks: 436069 447702
  Show dependency tree
 
Reported: 2014-05-27 05:53 EDT by Maxime Porhel CLA
Modified: 2014-10-17 09:33 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2014-05-27 05:53:31 EDT 
The "without layer mode" is not supported by Sirius. 

The new child menu corresponding to mappings as direct children of a (Sequence) Diagram Description should not be available in the VSM Editor. 

The new ToolSection menu is already disabled on a DiagramDescription but the reused tools section is not hidden. 

The reused tools and reused mappings property sections should not be displayed (the specifier should use the correpsonding section of the default layer).  

Furthermore, the Begin/InitialOperation direct child of the DiagramDescription should not be available too.
Comment 1 Maxime Porhel CLA 2014-05-27 06:26:15 EDT 
See   https://git.eclipse.org/r/27342 and https://git.eclipse.org/r/27343 for a correction
Comment 2 Maxime Porhel CLA 2014-05-27 06:26:59 EDT 
See https://git.eclipse.org/r/27344 for a proposed improvement: display Layer reusedMappings and reusedTools section in the import tab.
Comment 3 Maxime Porhel CLA 2014-05-28 07:33:05 EDT 
Fixed by commits:
 . 1818c687dd4bea8ce535abe3a4d5f2dabc40aa19
 . 7aeed2f81fdfddb4ddc8cd83c619b75b377078f6
 . ed17033efe034de256e0182868636a0289b34f5b
 . fe24cadba2bb4549cd6e62f59c235387e90fc0a5
Comment 4 Alex Lagarde CLA 2014-05-28 09:32:18 EDT 
The "Begin" entry was usefull to define actions called whenever a (Sequence) Diagram gets created.

It should be kept as child of Diagram Descriptions. We may decide to hide it by default and left consumers override this by displating the menu.
Comment 5 Maxime Porhel CLA 2014-05-28 10:24:10 EDT 
See org.eclipse.sirius.diagram.editor.tools.internal.editor.SiriusDiagramEditorCustomization.

The line        deprecation.add(DescriptionPackage.eINSTANCE.getDiagramDescription_DiagramInitialisation()); as it was added by error. 

See https://git.eclipse.org/r/27453


I add also removed the possibility to create Dot styles on Node mappings.

See https://git.eclipse.org/r/27454


The SetEObject model operation has also been disbled during this issue, but this should not be done from the sirius.editor.diagram plugin as it is an operation defin in the core metamodel. 

See https://git.eclipse.org/r/27455
Comment 6 Maxime Porhel CLA 2014-06-02 04:51:03 EDT 
Corrected by commits:
 . f27908c340c4491f3e676d179797c13e61da1cff
 . 763812c6f2c74a5b7f2b5891347f7c5150967ce7
 . 2a9e4aff487f8e9e5dfefaa11ca036519309fbb2
Comment 7 Maxime Porhel CLA 2014-06-04 03:26:05 EDT 
*** Bug 422683 has been marked as a duplicate of this bug. ***
Comment 8 Pierre-Charles David CLA 2014-06-10 07:08:01 EDT 
Verified on 1.0.0rc3.
Comment 9 Pierre-Charles David CLA 2014-06-25 10:15:04 EDT 
Available in Sirius 1.0.0.