435813 – Extension point missing doc: org.eclipse.e4.workbench.model.definition.enrichment (bundle org.eclipse.e4.ui.workbench)

Bug 435813 - Extension point missing doc: org.eclipse.e4.workbench.model.definition.enrichment (bundle org.eclipse.e4.ui.workbench)

Summary: Extension point missing doc: org.eclipse.e4.workbench.model.definition.enrich...

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.4 RC3
Assignee:	Paul Webster
QA Contact:

URL:
Whiteboard:
Keywords:	Documentation

Depends on:
Blocks:

Reported:	2014-05-26 13:05 EDT by Markus Keller
Modified:	2014-05-29 08:28 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Markus Keller

2014-05-26 13:05:08 EDT

4.2 RC2.

The 'org.eclipse.e4.workbench.model.definition.enrichment' extension point does not appear in the doc.

Is it in the same state as bug 380891, i.e. should be marked as non-API and added to org.eclipse.platform.doc.isv?

Comment 1 Markus Keller

2014-05-26 13:28:29 EDT

You should not try to externalize the extension point name in org.eclipse.e4.workbench.model.definition.enrichment.exsd. Iff schema files ever get translated, then their complete text content would have to be translated.

Comment 2 Paul Webster

2014-05-27 09:18:56 EDT

Lars, Rene, we need a fix for this by tomorrow.

PW

Comment 3 Lars Vogel

2014-05-27 10:47:47 EDT

(In reply to Paul Webster from comment #2)
> Lars, Rene, we need a fix for this by tomorrow.
> 
> PW

I don't remember that I was involved in this development. Rene is currently ill AFAIK. Is this the extension point to register model extension so that EModelService.createModelElement() finds it?

Comment 4 Paul Webster

2014-05-27 11:14:22 EDT

OK, we'll follow the Bug 380891 route

PW

Comment 5 Wojciech Sudol

2014-05-28 12:30:32 EDT

Review URLs:
  https://git.eclipse.org/r/27478
  https://git.eclipse.org/r/27479

Comment 6 Paul Webster

2014-05-28 14:02:21 EDT

Released as http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4b401dad6b1872785e53c41abfe2cbcf5bc70608 and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=75ecc7dfa3398a06841c5fc06e50d34ccbd5bff1

PW

Comment 7 Missing name Mising name

2014-05-29 06:13:35 EDT

Sorry about that I had a hand plaster, which is now gone. Thank you very much Wojciech for providing the missing pieces.

Comment 8 Dani Megert

2014-05-29 08:28:29 EDT

Verified in I20140528-2000.